From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Linux PM list <linux-pm@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Alan Stern <stern@rowland.harvard.edu>
Subject: [PATCH 1/3] PM / Runtime: Fix rpm_resume() return value for power.no_callbacks set
Date: Tue, 14 Aug 2012 23:38:18 +0200 [thread overview]
Message-ID: <201208142338.18797.rjw@sisk.pl> (raw)
In-Reply-To: <201208142334.45452.rjw@sisk.pl>
For devices whose power.no_callbacks flag is set, rpm_resume()
should return 1 if the device's parent is already active, so that
the callers of pm_runtime_get() don't think that they have to wait
for the device to resume (asynchronously) in that case (the core
won't queue up an asynchronous resume in that case, so there's
nothing to wait for anyway).
Modify the code accordingly (and make sure that an idle notification
will be queued up on success, even if 1 is to be returned).
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
drivers/base/power/runtime.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: linux/drivers/base/power/runtime.c
===================================================================
--- linux.orig/drivers/base/power/runtime.c
+++ linux/drivers/base/power/runtime.c
@@ -584,6 +584,7 @@ static int rpm_resume(struct device *dev
|| dev->parent->power.runtime_status == RPM_ACTIVE) {
atomic_inc(&dev->parent->power.child_count);
spin_unlock(&dev->parent->power.lock);
+ retval = 1;
goto no_callback; /* Assume success. */
}
spin_unlock(&dev->parent->power.lock);
@@ -664,7 +665,7 @@ static int rpm_resume(struct device *dev
}
wake_up_all(&dev->power.wait_queue);
- if (!retval)
+ if (retval >= 0)
rpm_idle(dev, RPM_ASYNC);
out:
next prev parent reply other threads:[~2012-08-14 21:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 21:34 [PATCH 0/3] PM / Runtime: rpm_suspend() and rpm_resume() fixes Rafael J. Wysocki
2012-08-14 21:38 ` Rafael J. Wysocki [this message]
2012-08-15 16:14 ` [PATCH 1/3] PM / Runtime: Fix rpm_resume() return value for power.no_callbacks set Alan Stern
2012-08-14 21:40 ` [PATCH 2/3] PM / Runtime: Clear power.deferred_resume on success in rpm_suspend() Rafael J. Wysocki
2012-08-15 16:19 ` Alan Stern
2012-08-14 21:41 ` [PATCH 3/3] PM / Runtime: Check device PM QoS setting before "no callbacks" check Rafael J. Wysocki
2012-08-15 16:20 ` Alan Stern
2012-08-15 18:22 ` [Update][PATCH " Rafael J. Wysocki
2012-08-15 18:23 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208142338.18797.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome