From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Linux PM list <linux-pm@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Alan Stern <stern@rowland.harvard.edu>
Subject: [PATCH 3/3] PM / Runtime: Check device PM QoS setting before "no callbacks" check
Date: Tue, 14 Aug 2012 23:41:50 +0200 [thread overview]
Message-ID: <201208142341.50852.rjw@sisk.pl> (raw)
In-Reply-To: <201208142334.45452.rjw@sisk.pl>
If __dev_pm_qos_read_value(dev) returns a negative value,
rpm_suspend() should return -EPERM for dev even if its
power.no_callbacks flag is set. For this to happen, the device's
power.no_callbacks flag has to be checked after the PM QoS check,
so modify the code accordingly.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
drivers/base/power/runtime.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
Index: linux/drivers/base/power/runtime.c
===================================================================
--- linux.orig/drivers/base/power/runtime.c
+++ linux/drivers/base/power/runtime.c
@@ -388,6 +388,12 @@ static int rpm_suspend(struct device *de
goto repeat;
}
+ if (__dev_pm_qos_read_value(dev) < 0) {
+ /* Negative PM QoS constraint means "never suspend". */
+ retval = -EPERM;
+ goto out;
+ }
+
if (dev->power.no_callbacks)
goto no_callback; /* Assume success. */
@@ -402,12 +408,6 @@ static int rpm_suspend(struct device *de
goto out;
}
- if (__dev_pm_qos_read_value(dev) < 0) {
- /* Negative PM QoS constraint means "never suspend". */
- retval = -EPERM;
- goto out;
- }
-
__update_runtime_status(dev, RPM_SUSPENDING);
if (dev->pm_domain)
next prev parent reply other threads:[~2012-08-14 21:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 21:34 [PATCH 0/3] PM / Runtime: rpm_suspend() and rpm_resume() fixes Rafael J. Wysocki
2012-08-14 21:38 ` [PATCH 1/3] PM / Runtime: Fix rpm_resume() return value for power.no_callbacks set Rafael J. Wysocki
2012-08-15 16:14 ` Alan Stern
2012-08-14 21:40 ` [PATCH 2/3] PM / Runtime: Clear power.deferred_resume on success in rpm_suspend() Rafael J. Wysocki
2012-08-15 16:19 ` Alan Stern
2012-08-14 21:41 ` Rafael J. Wysocki [this message]
2012-08-15 16:20 ` [PATCH 3/3] PM / Runtime: Check device PM QoS setting before "no callbacks" check Alan Stern
2012-08-15 18:22 ` [Update][PATCH " Rafael J. Wysocki
2012-08-15 18:23 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208142341.50852.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome