From: Kent Overstreet <koverstreet@google.com>
To: Tejun Heo <tj@kernel.org>
Cc: linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org,
dm-devel@redhat.com, axboe@kernel.dk
Subject: Re: [PATCH 0/9] Prep work for immutable bio vecs
Date: Sun, 9 Sep 2012 18:21:02 -0700 [thread overview]
Message-ID: <20120910012101.GB23241@moria.home.lan> (raw)
In-Reply-To: <20120908194115.GC12773@dhcp-172-17-108-109.mtv.corp.google.com>
On Sat, Sep 08, 2012 at 12:41:15PM -0700, Tejun Heo wrote:
> Hello, Kent.
>
> On Fri, Sep 07, 2012 at 03:59:11PM -0700, Kent Overstreet wrote:
> > Random assortment of refactoring and trivial cleanups.
> >
> > Immutable bio vecs and efficient bio splitting require auditing and removing
> > pretty much all bi_idx uses, among other things.
> >
> > The reason is that with immutable bio vecs we can't use the bvec array
> > directly; if we have a partially completed bvec, that'll be indicated with a
> > field in struct bvec_iter (which gets embedded in struct bio) - bi_bvec_done.
> >
> > bio_for_each_segments() will handle this transparently, so code needs to be
> > converted to use it or some other generic accessor.
> >
> > Also, bio splitting means that when a driver gets a bio, bi_idx and
> > bi_bvec_done may both be nonzero. Again, just need to use generic accessors.
>
> There are three pending patchsets and I don't know how they're
> supposed to come together. Please explain on which tree the patches
> are based and how they stack and preferably provide a git branch.
Both of the new ones depend on the block cleanups series, but they
shouldn't depend on each other (bar perhaps some trivial merge
conflicts in bio.h)
Git repo - block_stuff branch on http://evilpiepirate.org/git/linux-bcache.git/
prev parent reply other threads:[~2012-09-10 1:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 22:59 Kent Overstreet
2012-09-07 22:59 ` [PATCH 1/9] block: Convert integrity to bvec_alloc_bs(), and a bugfix Kent Overstreet
2012-09-07 22:59 ` [PATCH 2/9] block: Add bio_advance() Kent Overstreet
2012-09-07 22:59 ` [PATCH 3/9] block: Refactor blk_update_request() Kent Overstreet
2012-09-07 22:59 ` [PATCH 4/9] md: Convert md_trim_bio() to use bio_advance() Kent Overstreet
2012-09-07 22:59 ` [PATCH 5/9] block: Add bio_end() Kent Overstreet
2012-09-07 22:59 ` [PATCH 6/9] block: Use bio_sectors() more consistently Kent Overstreet
2012-09-07 22:59 ` [PATCH 7/9] block: Don't use bi_idx in bio_split() or require it to be 0 Kent Overstreet
2012-09-07 22:59 ` [PATCH 8/9] block: Remove bi_idx references Kent Overstreet
2012-09-07 22:59 ` [PATCH 9/9] block: Remove some unnecessary bi_vcnt usage Kent Overstreet
2012-09-08 19:41 ` [PATCH 0/9] Prep work for immutable bio vecs Tejun Heo
2012-09-10 1:21 ` Kent Overstreet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120910012101.GB23241@moria.home.lan \
--to=koverstreet@google.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®