* [PATCH] max17042: missing assignment
@ 2012-10-01 16:09 Alan Cox
0 siblings, 0 replies; only message in thread
From: Alan Cox @ 2012-10-01 16:09 UTC (permalink / raw)
To: ramakrishna.pallala, linux-kernel
From: Alan Cox <alan@linux.intel.com>
The second error check is unreachable because the lock function
isn't assigned to ret
Signed-off-by: Alan Cox <alan@linux.intel.com>
---
drivers/power/max17042_battery.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/max17042_battery.c b/drivers/power/max17042_battery.c
index 74abc6c..73b432d 100644
--- a/drivers/power/max17042_battery.c
+++ b/drivers/power/max17042_battery.c
@@ -572,7 +572,7 @@ static int max17042_init_chip(struct max17042_chip *chip)
__func__);
return -EIO;
}
- max17042_verify_model_lock(chip);
+ ret = max17042_verify_model_lock(chip);
if (ret) {
dev_err(&chip->client->dev, "%s lock verify failed\n",
__func__);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2012-10-01 15:50 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-01 16:09 [PATCH] max17042: missing assignment Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®