From: Sascha Hauer <s.hauer@pengutronix.de>
To: Thierry Reding <thierry.reding@avionic-design.de>
Cc: linux-kernel@vger.kernel.org, "Shawn Guo" <shawn.guo@linaro.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>,
"Stephen Warren" <swarren@wwwdotorg.org>
Subject: Re: [PATCH] pwm: dt: Fix description of second PWM cell
Date: Fri, 5 Oct 2012 17:24:43 +0200 [thread overview]
Message-ID: <20121005152443.GW1322@pengutronix.de> (raw)
In-Reply-To: <1349074053-18385-1-git-send-email-thierry.reding@avionic-design.de>
On Mon, Oct 01, 2012 at 08:47:33AM +0200, Thierry Reding wrote:
> The second cell in the PWM specifier denotes the period in nanoseconds,
> not the duty cycle. The latter can be freely configured at runtime and
> a PWM with a fixed duty cycle would be rather pointless.
>
> Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
> Cc: Shawn Guo <shawn.guo@linaro.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
> Cc: Stephen Warren <swarren@wwwdotorg.org>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> Documentation/devicetree/bindings/pwm/imx-pwm.txt | 2 +-
> Documentation/devicetree/bindings/pwm/mxs-pwm.txt | 2 +-
> Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pwm/imx-pwm.txt b/Documentation/devicetree/bindings/pwm/imx-pwm.txt
> index 9b9b185..8522bfb 100644
> --- a/Documentation/devicetree/bindings/pwm/imx-pwm.txt
> +++ b/Documentation/devicetree/bindings/pwm/imx-pwm.txt
> @@ -4,7 +4,7 @@ Required properties:
> - compatible: should be "fsl,<soc>-pwm"
> - reg: physical base address and length of the controller's registers
> - #pwm-cells: should be 2. The first cell specifies the per-chip index
> - of the PWM to use and the second cell is the duty cycle in nanoseconds.
> + of the PWM to use and the second cell is the period in nanoseconds.
> - interrupts: The interrupt for the pwm controller
>
> Example:
> diff --git a/Documentation/devicetree/bindings/pwm/mxs-pwm.txt b/Documentation/devicetree/bindings/pwm/mxs-pwm.txt
> index b16f4a5..d7946be6 100644
> --- a/Documentation/devicetree/bindings/pwm/mxs-pwm.txt
> +++ b/Documentation/devicetree/bindings/pwm/mxs-pwm.txt
> @@ -4,7 +4,7 @@ Required properties:
> - compatible: should be "fsl,imx23-pwm"
> - reg: physical base address and length of the controller's registers
> - #pwm-cells: should be 2. The first cell specifies the per-chip index
> - of the PWM to use and the second cell is the duty cycle in nanoseconds.
> + of the PWM to use and the second cell is the period in nanoseconds.
> - fsl,pwm-number: the number of PWM devices
>
> Example:
> diff --git a/Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt b/Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt
> index bbbeedb..01438ec 100644
> --- a/Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt
> +++ b/Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt
> @@ -7,7 +7,7 @@ Required properties:
> - reg: physical base address and length of the controller's registers
> - #pwm-cells: On Tegra the number of cells used to specify a PWM is 2. The
> first cell specifies the per-chip index of the PWM to use and the second
> - cell is the duty cycle in nanoseconds.
> + cell is the period in nanoseconds.
>
> Example:
>
> --
> 1.7.12.2
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2012-10-05 15:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-01 6:47 Thierry Reding
2012-10-05 15:24 ` Sascha Hauer [this message]
2012-10-07 3:16 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121005152443.GW1322@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=benoit.thebaudeau@advansee.com \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=shawn.guo@linaro.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®