From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: mathieu.poirier@linaro.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, rdunlap@xenotime.net,
arve@android.com, kernel-team@android.com,
john.stultz@linaro.org
Subject: Re: [PATCH] drivers/tty: Folding Android's keyreset driver in sysRQ
Date: Fri, 5 Oct 2012 19:53:03 +0100 [thread overview]
Message-ID: <20121005195303.6e652997@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <20121005181608.GA24356@core.coreip.homeip.net>
> I have the same objection as before: using platform device solely for
> the purpose of passing some data from board code to the driver. Surely
> there are other ways of passing this bit of data... What about, for
> example, making it an empty weak symbol so that board code could
> override it with strong one?
I have the same objection to it being passed in other weird ways. This is
cross architecture, cross device stuff. Magic architecture goo and weak
symbols are not the right solution.
The reset switch is a device, physically and logically.
Alan
next prev parent reply other threads:[~2012-10-05 18:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 17:59 mathieu.poirier
2012-10-05 18:16 ` Dmitry Torokhov
2012-10-05 18:53 ` Alan Cox [this message]
2012-10-05 19:08 ` Dmitry Torokhov
2012-10-05 19:48 ` Mathieu Poirier
2012-10-17 3:35 ` Arve Hjønnevåg
2012-10-20 16:38 ` Mathieu Poirier
2012-10-21 6:19 ` Dmitry Torokhov
-- strict thread matches above, loose matches on Subject: below --
2012-08-27 21:43 mathieu.poirier
2012-08-27 23:34 ` Randy Dunlap
2012-08-28 10:55 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121005195303.6e652997@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=arve@android.com \
--cc=dmitry.torokhov@gmail.com \
--cc=john.stultz@linaro.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome