[PATCH RESEND] umc-bus.c: fix usage of device_trylock

[PATCH RESEND] umc-bus.c: fix usage of device_trylock

[Claudio Scordino]

Hi all.

I've not received any feedback about this patch, so I'm resending just
to check if someone is going to take care of it.

The patch fixes the usage of device_trylock inside the driver umc-bus.c:
device_trylock has the same semantics of mutex_trylock, so it returns 1
if the lock has been acquired successfully.

Best regards,

	Claudio


Subject: umc-bus.c: fix usage of device_trylock
From: Claudio Scordino <claudio@evidence.eu.com>

Fix usage of device_trylock. It has the same semantics of mutex_trylock, so it
returns 1 if the lock has been acquired successfully.

Signed-off-by: Claudio Scordino <claudio@evidence.eu.com>
Signed-off-by: Bruno Morelli <bruno@evidence.eu.com>
---
  drivers/uwb/umc-bus.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/uwb/umc-bus.c b/drivers/uwb/umc-bus.c
index 82a84d5..5c5b3fc 100644
--- a/drivers/uwb/umc-bus.c
+++ b/drivers/uwb/umc-bus.c
@@ -63,7 +63,7 @@ int umc_controller_reset(struct umc_dev *umc)
  	struct device *parent = umc->dev.parent;
  	int ret = 0;
  
-	if (device_trylock(parent))
+	if (!device_trylock(parent))
  		return -EAGAIN;
  	ret = device_for_each_child(parent, parent, umc_bus_pre_reset_helper);
  	if (ret >= 0)
-- 
1.7.1

Re: [PATCH RESEND] umc-bus.c: fix usage of device_trylock

[Greg KH]

On Tue, Oct 09, 2012 at 12:21:17PM +0200, Claudio Scordino wrote:
> Hi all.
> 
> I've not received any feedback about this patch, so I'm resending just
> to check if someone is going to take care of it.

It was sent in the middle of the merge window, when we are scrambling to
get other stuff done.  It's still in my queue and will be handled after
3.7-rc1 is out, and I've caught up on my travel.

thanks,

greg k-h