From: Shawn Guo <shawn.guo@linaro.org>
To: Yong Ding <yongd@marvell.com>
Cc: Chris Ball <cjb@laptop.org>,
Anton Vorontsov <anton.vorontsov@linaro.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Wolfram Sang <w.sang@pengutronix.de>,
Daniel Drake <dsd@laptop.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Wilson Callan <wilson.callan@savantsystems.com>,
Ben Dooks <ben-linux@fluff.org>, Zhangfei Gao <zgao6@marvell.com>,
Kevin Liu <kliu5@marvell.com>, Jialing Fu <jlfu@marvell.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] mmc: esdhc: enable polling to detect card by itself
Date: Thu, 18 Oct 2012 14:38:27 +0800 [thread overview]
Message-ID: <20121018063825.GC4513@S2101-09.ap.freescale.net> (raw)
In-Reply-To: <89813612683626448B837EE5A0B6A7CB3038855FF9@SC-VEXCH4.marvell.com>
Can you fix your mailer to use bottom posting rather than top posting,
and have texts wrap around column 70? Otherwise, you message stands
a good chance to be ignored by people.
On Wed, Oct 17, 2012 at 11:27:17PM -0700, Yong Ding wrote:
> Shawn,
> Thanks. Oh, sorry I really have missed the fact u mentioned. U are right in the current code, the bit will also be cleared for ESDHC_CD_GPIO.
> But I think this is improper since for GPIO detection type, we don't use the host controller internal card detection(ESDHC_CD_CONTROLLER), but with SDHCI_QUIRK_BROKEN_CARD_DETECTION cleared, we'll still enable/disable relevant INT bits (in sdhci_set_card_detection in sdhci.c). This is my biggest concern. And I think the SDHCI_QUIRK_BROKEN_CARD_DETECTION shall be purely used to notify whether the host controller detection method is used or not. So even for the ESDHC_CD_GPIO type, we should still set this flag. How do u think?
>
I'm fine with that. Just remind you a fact you seem missed in case
you need to change sdhci-esdhc-imx.c to adapt the changes you are going
to make on sdhci.c.
Shawn
next prev parent reply other threads:[~2012-10-18 6:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 10:28 yongd
2012-09-28 10:28 ` [PATCH 1/3] mmc: esdhc: enable polling to detect card by itself yongd
2012-10-07 14:06 ` Shawn Guo
2012-10-17 4:01 ` Yong Ding
2012-10-18 5:50 ` Shawn Guo
2012-10-18 6:27 ` Yong Ding
2012-10-18 6:38 ` Shawn Guo [this message]
2012-10-18 7:19 ` Yong Ding
2012-09-28 10:28 ` [PATCH 2/3] mmc: sdhci-s3c: " yongd
2012-09-28 10:28 ` [PATCH 3/3] mmc: remove MMC_CAP_NEEDS_POLL setting in sdhci_add_host yongd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121018063825.GC4513@S2101-09.ap.freescale.net \
--to=shawn.guo@linaro.org \
--cc=anton.vorontsov@linaro.org \
--cc=ben-linux@fluff.org \
--cc=cjb@laptop.org \
--cc=dsd@laptop.org \
--cc=jlfu@marvell.com \
--cc=kliu5@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=s.hauer@pengutronix.de \
--cc=w.sang@pengutronix.de \
--cc=wilson.callan@savantsystems.com \
--cc=yongd@marvell.com \
--cc=zgao6@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®