From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Stephane Eranian <eranian@google.com>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
"mingo@elte.hu" <mingo@elte.hu>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH 1/2] perf tools: add event modifier to request exclusive PMU access
Date: Fri, 19 Oct 2012 18:07:25 +0200 [thread overview]
Message-ID: <20121019160724.GE980@krava.brq.redhat.com> (raw)
In-Reply-To: <20121019154610.GX2095@tassilo.jf.intel.com>
On Fri, Oct 19, 2012 at 08:46:10AM -0700, Andi Kleen wrote:
> > That's what I thought too, but then I don't understand why it was at
> > eight before and not
> > seven: One instance of each letter, + a second for pp (precise=2). Or
> > am I missing
> > something here?
>
> The number is pretty useless imho (it's unlikely to catch any real user error)
> and most likely generates a much longer automata in flex than just a +
> So I would drop it.
yep, probably we could do better job with checking the modifier
after parsing (with just + in flex) ... added in my todo ;)
jirka
next prev parent reply other threads:[~2012-10-19 16:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 14:52 [PATCH 0/2] perf: enforce exclusive PMU access for SNB INST_RETIRED:PREC_DIST Stephane Eranian
2012-10-19 14:52 ` [PATCH 1/2] perf tools: add event modifier to request exclusive PMU access Stephane Eranian
2012-10-19 15:13 ` Peter Zijlstra
2012-10-19 15:17 ` Stephane Eranian
2012-10-19 15:23 ` Jiri Olsa
2012-10-19 15:47 ` Stephane Eranian
2012-10-19 15:53 ` Jiri Olsa
2012-10-19 15:58 ` Stephane Eranian
2012-10-19 15:46 ` Andi Kleen
2012-10-19 16:07 ` Jiri Olsa [this message]
2012-10-19 14:52 ` [PATCH 2/2] perf: SNB exclusive PMU access for INST_RETIRED:PREC_DIST Stephane Eranian
2012-10-19 15:49 ` Andi Kleen
2012-10-19 15:58 ` Stephane Eranian
2012-10-19 16:27 ` Peter Zijlstra
2012-10-19 16:31 ` Stephane Eranian
2012-10-19 16:45 ` Peter Zijlstra
2012-10-19 17:20 ` Andi Kleen
2012-10-21 16:55 ` Ingo Molnar
2012-10-21 17:54 ` Stephane Eranian
2012-10-21 18:03 ` Ingo Molnar
2012-10-22 11:31 ` Stephane Eranian
2012-10-24 8:15 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121019160724.GE980@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome