From: Borislav Petkov <bp@amd64.org>
To: Tang Chen <tangchen@cn.fujitsu.com>, Tony Luck <tony.luck@intel.com>
Cc: stable@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, miaox@cn.fujitsu.com, laijs@cn.fujitsu.com,
wency@cn.fujitsu.com, x86@kernel.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org, Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH v2 2/2] Do not change worker's running cpu in cmci_rediscover().
Date: Fri, 19 Oct 2012 18:42:33 +0200 [thread overview]
Message-ID: <20121019164233.GF11958@aftab.osrc.amd.com> (raw)
In-Reply-To: <1350625528-1385-3-git-send-email-tangchen@cn.fujitsu.com>
On Fri, Oct 19, 2012 at 01:45:28PM +0800, Tang Chen wrote:
> cmci_rediscover() used set_cpus_allowed_ptr() to change the current process's
> running cpu, and migrate itself to the dest cpu. But worker processes are not
> allowed to be migrated. If current is a worker, the worker will be migrated to
> another cpu, but the corresponding worker_pool is still on the original cpu.
>
> In this case, the following BUG_ON in try_to_wake_up_local() will be triggered:
> BUG_ON(rq != this_rq());
>
> This will cause the kernel panic.
>
> This patch removes the set_cpus_allowed_ptr() call, and put the cmci rediscover
> jobs onto all the other cpus using system_wq. This could bring some delay for
> the jobs.
>
> Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
> Signed-off-by: Miao Xie <miaox@cn.fujitsu.com>
I guess this is ok. Tony?
--
Regards/Gruss,
Boris.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
next prev parent reply other threads:[~2012-10-19 16:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 5:45 [PATCH v2 0/2] " Tang Chen
2012-10-19 5:45 ` [PATCH v2 1/2] Replace if statement with WARN_ON_ONCE() " Tang Chen
2012-10-19 14:07 ` Greg KH
2012-10-19 16:40 ` Borislav Petkov
2012-10-22 2:10 ` Tang Chen
2012-10-22 10:14 ` Borislav Petkov
2012-10-23 1:35 ` Tang Chen
2012-10-23 2:55 ` Tang Chen
2012-10-23 9:52 ` Borislav Petkov
2012-10-23 10:17 ` Miao Xie
2012-10-23 10:20 ` Borislav Petkov
2012-10-23 10:34 ` Miao Xie
2012-10-23 13:14 ` Borislav Petkov
2012-10-23 11:30 ` Tang Chen
2012-10-23 14:17 ` Borislav Petkov
2012-10-23 16:16 ` Luck, Tony
2012-10-24 1:31 ` Tang Chen
2012-10-19 5:45 ` [PATCH v2 2/2] Do not change worker's running cpu " Tang Chen
2012-10-19 16:42 ` Borislav Petkov [this message]
2012-10-19 17:21 ` Luck, Tony
2012-10-22 3:33 ` Tang Chen
2012-10-22 10:18 ` Borislav Petkov
2012-10-23 1:30 ` Tang Chen
2012-10-19 7:21 ` [PATCH v2 0/2] " Tang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121019164233.GF11958@aftab.osrc.amd.com \
--to=bp@amd64.org \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miaox@cn.fujitsu.com \
--cc=mingo@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tangchen@cn.fujitsu.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=wency@cn.fujitsu.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome