* Re: [PATCH] rcu: Fix the code style issue in rcutree_trace_init()
[not found] <1351479733-6978-1-git-send-email-wangyun@linux.vnet.ibm.com>
@ 2012-10-29 9:49 ` Paul E. McKenney
0 siblings, 0 replies; only message in thread
From: Paul E. McKenney @ 2012-10-29 9:49 UTC (permalink / raw)
To: Michael Wang; +Cc: linux-kernel, dipankar, fengguang.wu
On Mon, Oct 29, 2012 at 11:02:13AM +0800, Michael Wang wrote:
> This patch fix the code style issue caused by:
>
> commit 622afdb3bd6288837a37bac137dfeff4e771798d
> "rcu: Optimize the 'rcudata' for RCU trace"
Queued, thank you Michael.
Thanx, Paul
> Signed-off-by: Michael Wang <wangyun@linux.vnet.ibm.com>
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> kernel/rcutree_trace.c | 60 ++++++++++++++++++++++++------------------------
> 1 files changed, 30 insertions(+), 30 deletions(-)
>
> diff --git a/kernel/rcutree_trace.c b/kernel/rcutree_trace.c
> index 73abfb0..e84679c 100644
> --- a/kernel/rcutree_trace.c
> +++ b/kernel/rcutree_trace.c
> @@ -436,44 +436,44 @@ static int __init rcutree_trace_init(void)
> if (!rspdir)
> goto free_out;
>
> - retval = debugfs_create_file("rcudata", 0444,
> - rspdir, rsp, &rcudata_fops);
> - if (!retval)
> - goto free_out;
> + retval = debugfs_create_file("rcudata", 0444,
> + rspdir, rsp, &rcudata_fops);
> + if (!retval)
> + goto free_out;
>
> - retval = debugfs_create_file("rcuexp", 0444,
> - rspdir, rsp, &rcuexp_fops);
> - if (!retval)
> - goto free_out;
> + retval = debugfs_create_file("rcuexp", 0444,
> + rspdir, rsp, &rcuexp_fops);
> + if (!retval)
> + goto free_out;
>
> - retval = debugfs_create_file("rcu_pending", 0444,
> - rspdir, rsp, &rcu_pending_fops);
> - if (!retval)
> - goto free_out;
> + retval = debugfs_create_file("rcu_pending", 0444,
> + rspdir, rsp, &rcu_pending_fops);
> + if (!retval)
> + goto free_out;
>
> - retval = debugfs_create_file("rcubarrier", 0444,
> - rspdir, rsp, &rcubarrier_fops);
> - if (!retval)
> - goto free_out;
> + retval = debugfs_create_file("rcubarrier", 0444,
> + rspdir, rsp, &rcubarrier_fops);
> + if (!retval)
> + goto free_out;
>
> #ifdef CONFIG_RCU_BOOST
> - if (rsp == &rcu_preempt_state) {
> - retval = debugfs_create_file("rcuboost", 0444,
> - rspdir, NULL, &rcu_node_boost_fops);
> - if (!retval)
> - goto free_out;
> - }
> -#endif
> -
> - retval = debugfs_create_file("rcugp", 0444,
> - rspdir, rsp, &rcugp_fops);
> + if (rsp == &rcu_preempt_state) {
> + retval = debugfs_create_file("rcuboost", 0444,
> + rspdir, NULL, &rcu_node_boost_fops);
> if (!retval)
> goto free_out;
> + }
> +#endif
>
> - retval = debugfs_create_file("rcuhier", 0444,
> - rspdir, rsp, &rcuhier_fops);
> - if (!retval)
> - goto free_out;
> + retval = debugfs_create_file("rcugp", 0444,
> + rspdir, rsp, &rcugp_fops);
> + if (!retval)
> + goto free_out;
> +
> + retval = debugfs_create_file("rcuhier", 0444,
> + rspdir, rsp, &rcuhier_fops);
> + if (!retval)
> + goto free_out;
> }
>
> retval = debugfs_create_file("rcutorture", 0444, rcudir,
> --
> 1.7.4.1
>
^ permalink raw reply [flat|nested] only message in thread