From: Al Viro <viro@ZenIV.linux.org.uk>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org,
Russell King <linux@arm.linux.org.uk>,
Will Deacon <will.deacon@arm.com>, Will Drewry <wad@chromium.org>,
Geremy Condra <gcondra@google.com>
Subject: Re: [PATCH 2/4] arch/arm: move secure_computing into trace
Date: Tue, 30 Oct 2012 02:05:00 +0000 [thread overview]
Message-ID: <20121030020500.GA2616@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1351557682-20983-3-git-send-email-keescook@chromium.org>
On Mon, Oct 29, 2012 at 05:41:20PM -0700, Kees Cook wrote:
> From: Will Drewry <wad@chromium.org>
>
> There is very little difference in the TIF_SECCOMP and TIF_SYSCALL_TRACE
> path in entry-common.S. In order to add support for
> CONFIG_HAVE_ARCH_SECCOMP_FILTER without mangling the assembly too badly,
> seccomp was moved into the syscall_trace_enter() handler.
>
> Additionally, the return value for secure_computing() is now checked
> and a -1 value will result in the system call being skipped.
This is too ugly. Just expand the calls of ptrace_syscall_trace() into
both callers and do secure_computing() hookup in there. And for pity
sake, would somebody rename the damn thing? It's *dripping* with
marketdroidese...
next prev parent reply other threads:[~2012-10-30 2:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 0:41 [PATCH 0/4] arch/arm: support seccomp Kees Cook
2012-10-30 0:41 ` [PATCH 1/4] arch/arm: add syscall_get_arch Kees Cook
2012-10-30 0:41 ` [PATCH 2/4] arch/arm: move secure_computing into trace Kees Cook
2012-10-30 2:05 ` Al Viro [this message]
2012-10-31 0:13 ` Kees Cook
2012-10-30 0:41 ` [PATCH 3/4] arch/arm: allow a scno of -1 to not cause a SIGILL Kees Cook
2012-10-30 0:41 ` [PATCH 4/4] arch/arm: select HAVE_ARCH_SECCOMP_FILTER Kees Cook
2012-11-01 19:46 [PATCH v2 0/4] arch/arm: support seccomp Kees Cook
2012-11-01 19:46 ` [PATCH 2/4] arch/arm: move secure_computing into trace Kees Cook
2012-11-01 20:33 ` Russell King - ARM Linux
2012-11-01 20:50 ` Kees Cook
2012-11-02 0:14 [PATCH v3 0/4] arch/arm: support seccomp Kees Cook
2012-11-02 0:14 ` [PATCH 2/4] arch/arm: move secure_computing into trace Kees Cook
2012-11-08 20:59 [PATCH v4 0/4] arch/arm: support seccomp Kees Cook
2012-11-08 20:59 ` [PATCH 2/4] arch/arm: move secure_computing into trace Kees Cook
2012-11-09 11:56 ` Will Deacon
2012-11-10 22:44 [PATCH v5 0/4] arch/arm: support seccomp Kees Cook
2012-11-10 22:44 ` [PATCH 2/4] arch/arm: move secure_computing into trace Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121030020500.GA2616@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=gcondra@google.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=wad@chromium.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome