From: Felipe Balbi <balbi@ti.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Viresh Kumar <viresh.linux@gmail.com>,
Vinod Koul <vinod.koul@intel.com>, <linux-kernel@vger.kernel.org>,
spear-devel <spear-devel@list.st.com>
Subject: Re: [PATCH 2/3] dma: move dw_dmac driver to an own directory
Date: Tue, 30 Oct 2012 14:35:15 +0200 [thread overview]
Message-ID: <20121030123515.GE29095@arwen.pp.htv.fi> (raw)
In-Reply-To: <1351600332-29443-3-git-send-email-andriy.shevchenko@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1545 bytes --]
Hi,
On Tue, Oct 30, 2012 at 02:32:11PM +0200, Andy Shevchenko wrote:
> The dw_dmac driver contains multiple files. To make a management of them more
> convenient move it to an own directory.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Felipe Balbi <balbi@ti.com>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> drivers/dma/Makefile | 3 +--
> drivers/dma/dw/Makefile | 2 ++
> drivers/dma/{ => dw}/dw_dmac.c | 2 +-
> drivers/dma/{ => dw}/dw_dmac_pci.c | 0
> drivers/dma/{ => dw}/dw_dmac_regs.h | 0
> 5 files changed, 4 insertions(+), 3 deletions(-)
> create mode 100644 drivers/dma/dw/Makefile
> rename drivers/dma/{ => dw}/dw_dmac.c (99%)
> rename drivers/dma/{ => dw}/dw_dmac_pci.c (100%)
> rename drivers/dma/{ => dw}/dw_dmac_regs.h (100%)
>
> diff --git a/drivers/dma/Makefile b/drivers/dma/Makefile
> index 15eef5f..122a48a 100644
> --- a/drivers/dma/Makefile
> +++ b/drivers/dma/Makefile
> @@ -11,8 +11,7 @@ obj-$(CONFIG_INTEL_IOP_ADMA) += iop-adma.o
> obj-$(CONFIG_FSL_DMA) += fsldma.o
> obj-$(CONFIG_MPC512X_DMA) += mpc512x_dma.o
> obj-$(CONFIG_MV_XOR) += mv_xor.o
> -obj-$(CONFIG_DW_DMAC) += dw_dmac.o
> -obj-$(CONFIG_DW_DMAC_PCI) += dw_dmac_pci.o
> +obj-$(CONFIG_DW_DMAC) += dw/
this is wrong, I guess. If you want dw_dmac_pci.o to be statically
built-in, but dw_dmac.o to be a dynamic module, according to this
Makefile entry, dw_dmac_pci.o will be linked to vmlinux.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-10-30 12:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 12:32 [PATCH 0/3] dw_dmac: add PCI driver and move dw stuff to its own folder Andy Shevchenko
2012-10-30 12:32 ` [PATCH 1/3] dmaengine: dw_dmac: add PCI part of the driver Andy Shevchenko
2012-10-30 12:32 ` [PATCH 2/3] dma: move dw_dmac driver to an own directory Andy Shevchenko
2012-10-30 12:35 ` Felipe Balbi [this message]
2012-10-30 12:32 ` [PATCH 3/3] MAINTAINERS: add recently created files to dw_dmac section Andy Shevchenko
2012-10-30 13:38 ` viresh kumar
2012-10-30 13:47 ` [PATCH 0/3] dw_dmac: add PCI driver and move dw stuff to its own folder viresh kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121030123515.GE29095@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=spear-devel@list.st.com \
--cc=vinod.koul@intel.com \
--cc=viresh.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®