* [PATCH] menuconfig: fix extended colors ncurses support
@ 2012-10-08 16:18 Krzysztof Mazur
2012-11-20 9:53 ` Michal Marek
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Mazur @ 2012-10-08 16:18 UTC (permalink / raw)
To: mmarek; +Cc: linux-kbuild, linux-kernel, Krzysztof Mazur
The ncurses library allows for extended colors. The support for extended
colors support depends on wide-character support. ncurses headers
enable extended colors (NCURSES_EXT_COLORS) only when wide-character
support is enabled (NCURSES_WIDECHAR).
The "make menuconfig" uses wide-character ncursesw library, which can be
compiled with wide-character support, but does not define NCURSES_WIDECHAR
and it's using headers without wide-character (and extended colors) support.
This fixes problems with colors on systems with enabled extended colors
(like PLD Linux). Without this patch "make menuconfig" is hard to use.
Signed-off-by: Krzysztof Mazur <krzysiek@podlesie.net>
---
scripts/kconfig/lxdialog/check-lxdialog.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/kconfig/lxdialog/check-lxdialog.sh b/scripts/kconfig/lxdialog/check-lxdialog.sh
index e3b12c0..5a70e8b 100644
--- a/scripts/kconfig/lxdialog/check-lxdialog.sh
+++ b/scripts/kconfig/lxdialog/check-lxdialog.sh
@@ -21,6 +21,7 @@ ccflags()
{
if [ -f /usr/include/ncursesw/curses.h ]; then
echo '-I/usr/include/ncursesw -DCURSES_LOC="<ncursesw/curses.h>"'
+ echo ' -DNCURSES_WIDECHAR=1'
elif [ -f /usr/include/ncurses/ncurses.h ]; then
echo '-I/usr/include/ncurses -DCURSES_LOC="<ncurses.h>"'
elif [ -f /usr/include/ncurses/curses.h ]; then
--
1.7.12.2.2.g1c3c581
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] menuconfig: fix extended colors ncurses support
2012-10-08 16:18 [PATCH] menuconfig: fix extended colors ncurses support Krzysztof Mazur
@ 2012-11-20 9:53 ` Michal Marek
2012-11-20 12:29 ` Krzysztof Mazur
0 siblings, 1 reply; 3+ messages in thread
From: Michal Marek @ 2012-11-20 9:53 UTC (permalink / raw)
To: Krzysztof Mazur; +Cc: linux-kbuild, linux-kernel
On Mon, Oct 08, 2012 at 06:18:22PM +0200, Krzysztof Mazur wrote:
> The ncurses library allows for extended colors. The support for extended
> colors support depends on wide-character support. ncurses headers
> enable extended colors (NCURSES_EXT_COLORS) only when wide-character
> support is enabled (NCURSES_WIDECHAR).
>
> The "make menuconfig" uses wide-character ncursesw library, which can be
> compiled with wide-character support, but does not define NCURSES_WIDECHAR
> and it's using headers without wide-character (and extended colors) support.
>
> This fixes problems with colors on systems with enabled extended colors
> (like PLD Linux). Without this patch "make menuconfig" is hard to use.
>
> Signed-off-by: Krzysztof Mazur <krzysiek@podlesie.net>
Applied to kbuild.git#kconfig, thanks.
Michal
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] menuconfig: fix extended colors ncurses support
2012-11-20 9:53 ` Michal Marek
@ 2012-11-20 12:29 ` Krzysztof Mazur
0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Mazur @ 2012-11-20 12:29 UTC (permalink / raw)
To: Michal Marek; +Cc: linux-kbuild, linux-kernel
On Tue, Nov 20, 2012 at 10:53:28AM +0100, Michal Marek wrote:
> On Mon, Oct 08, 2012 at 06:18:22PM +0200, Krzysztof Mazur wrote:
> > The ncurses library allows for extended colors. The support for extended
> > colors support depends on wide-character support. ncurses headers
> > enable extended colors (NCURSES_EXT_COLORS) only when wide-character
> > support is enabled (NCURSES_WIDECHAR).
> >
> > The "make menuconfig" uses wide-character ncursesw library, which can be
> > compiled with wide-character support, but does not define NCURSES_WIDECHAR
> > and it's using headers without wide-character (and extended colors) support.
> >
> > This fixes problems with colors on systems with enabled extended colors
> > (like PLD Linux). Without this patch "make menuconfig" is hard to use.
> >
> > Signed-off-by: Krzysztof Mazur <krzysiek@podlesie.net>
>
>
> Applied to kbuild.git#kconfig, thanks.
>
> Michal
Thanks,
Krzysiek
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-20 12:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-08 16:18 [PATCH] menuconfig: fix extended colors ncurses support Krzysztof Mazur
2012-11-20 9:53 ` Michal Marek
2012-11-20 12:29 ` Krzysztof Mazur
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®