Re: Tagging of -stable patches

Re: Tagging of -stable patches

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 934 bytes --]

Hi,

On Wed, Nov 21, 2012 at 06:44:45PM +0100, Jan Kara wrote:
>   Hello,
> 
>   I have a question regarding tagging of patches targetted in -stable
> kernels. We have this 'CC: stable@vger.kernel.org # something' tag. Now
> inconvenient thing is that when I create a patch and have such tag in it,
> then git-send-email will mangle the address because of the #. Now even if
> git-send-email started to ignore the part after #, we don't really want

I started a discussion with git mailing list about that, fix coming soon
;-)

> stable@vger.kernel.org to get the patch since it is eligible for -stable
> only after it is merged upstream. So the CC form of the tag seems to be
> kind of inconvenient. Won't it be better to have some different tag?

the stable "robots" know that they should only take a patch once it hits
upstream. Don't worry, just cc stable and let them handle the rest.

cheers

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Tagging of -stable patches

[Jan Kara]

  Hello,

  I have a question regarding tagging of patches targetted in -stable
kernels. We have this 'CC: stable@vger.kernel.org # something' tag. Now
inconvenient thing is that when I create a patch and have such tag in it,
then git-send-email will mangle the address because of the #. Now even if
git-send-email started to ignore the part after #, we don't really want
stable@vger.kernel.org to get the patch since it is eligible for -stable
only after it is merged upstream. So the CC form of the tag seems to be
kind of inconvenient. Won't it be better to have some different tag?

								Honza
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

Re: Tagging of -stable patches

[Ben Hutchings]

On Wed, Nov 21, 2012 at 06:44:45PM +0100, Jan Kara wrote:
>   Hello,
> 
>   I have a question regarding tagging of patches targetted in -stable
> kernels. We have this 'CC: stable@vger.kernel.org # something' tag. Now
> inconvenient thing is that when I create a patch and have such tag in it,
> then git-send-email will mangle the address because of the #. Now even if
> git-send-email started to ignore the part after #, we don't really want
> stable@vger.kernel.org to get the patch since it is eligible for -stable
> only after it is merged upstream. So the CC form of the tag seems to be
> kind of inconvenient. Won't it be better to have some different tag?
 
I don't have any particular attachment to this odd format, but I
would like to see *some* format properly standardised.  I want to be
able to script:

for each new commit cc'd to stable:
    if no version restriction is specified:
        add to patch queue(s) pending check for suitability
    elif version restriction can be parsed:
        add to patch queue(s) or drop based on version comparison
    else:
        show version restriction and ask whether/where to add it

...with as few questions asked as possible.  As yet, though, I haven't
bothered trying to parse the variety of different ways people write
version restrictions, but the script does require them to be preceded
by a '#'.

Ben.

-- 
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
                                                              - Albert Camus