From: Thierry Reding <thierry.reding@avionic-design.de>
To: "Philip, Avinash" <avinashphilip@ti.com>
Cc: paul@pwsan.com, tony@atomide.com, linux@arm.linux.org.uk,
b-cousson@ti.com, hvaibhav@ti.com, anilkumar@ti.com,
linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
nsekhar@ti.com, gururaja.hebbar@ti.com, vaibhav.bedia@ti.com,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
Rob Landley <rob@landley.net>
Subject: Re: [PATCH v4 06/11] pwm: pwm-tiehrpwm: Add device-tree binding support for EHRPWM driver
Date: Thu, 22 Nov 2012 22:03:47 +0100 [thread overview]
Message-ID: <20121122210347.GD16716@avionic-0098.adnet.avionic-design.de> (raw)
In-Reply-To: <1353503469-18634-7-git-send-email-avinashphilip@ti.com>
[-- Attachment #1: Type: text/plain, Size: 475 bytes --]
On Wed, Nov 21, 2012 at 06:41:03PM +0530, Philip, Avinash wrote:
[...]
> +static const struct of_device_id ehrpwm_of_match[] = {
> + {
> + .compatible = "ti,am33xx-ehrpwm",
> + },
Same comment as for patch 4.
> @@ -437,16 +451,41 @@ static int __devinit ehrpwm_pwm_probe(struct platform_device *pdev)
> dev_err(&pdev->dev, "pwmchip_add() failed: %d\n", ret);
> return ret;
> }
> -
I think this blank line actually improves readability so it can stay in.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-11-22 21:04 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 13:10 [PATCH v4 00/11] Support for AM33xx PWM Subsystem Philip, Avinash
2012-11-21 13:10 ` [PATCH v4 01/11] PWMSS: Add PWM Subsystem driver for parent<->child relationship Philip, Avinash
2012-11-22 20:47 ` Thierry Reding
2012-11-23 10:34 ` Philip, Avinash
2012-11-21 13:10 ` [PATCH v4 02/11] ARM: am33xx: clk: Add optional clock for EHRPWM Philip, Avinash
2012-11-21 13:11 ` [PATCH v4 03/11] ARM: OMAP: AM33xx hwmod: Add parent-child relationship for PWM subsystem Philip, Avinash
2012-11-21 13:11 ` [PATCH v4 04/11] pwm: pwm-tiecap: Add device-tree binding support for APWM driver Philip, Avinash
2012-11-22 20:57 ` Thierry Reding
2012-11-23 10:34 ` Philip, Avinash
2012-11-22 21:46 ` Thierry Reding
2012-11-21 13:11 ` [PATCH v4 05/11] pwm: pwm-tiecap: pinctrl support Philip, Avinash
2012-11-22 20:59 ` Thierry Reding
2012-11-23 10:34 ` Philip, Avinash
2012-11-23 10:51 ` Thierry Reding
2012-11-23 11:12 ` Philip, Avinash
2012-11-23 11:18 ` Thierry Reding
2012-11-23 12:48 ` Peter Korsgaard
2012-11-24 20:34 ` Thierry Reding
2012-11-27 14:20 ` Peter Korsgaard
2012-11-22 21:06 ` Thierry Reding
2012-11-21 13:11 ` [PATCH v4 06/11] pwm: pwm-tiehrpwm: Add device-tree binding support for EHRPWM driver Philip, Avinash
2012-11-22 21:03 ` Thierry Reding [this message]
2012-11-23 10:35 ` Philip, Avinash
2012-11-21 13:11 ` [PATCH v4 07/11] pwm: pwm-tiehrpwm: pinctrl support Philip, Avinash
2012-11-22 21:04 ` Thierry Reding
2012-11-21 13:11 ` [PATCH v4 08/11] pwm: pwm-tiehrpwm: Adding TBCLK gating support Philip, Avinash
2012-11-22 21:05 ` Thierry Reding
2012-11-21 13:11 ` [PATCH v4 09/11] ARM: dts: AM33XX: Add PWMSS device tree nodes Philip, Avinash
2012-11-22 21:08 ` Thierry Reding
2012-11-23 10:35 ` Philip, Avinash
2012-11-21 13:11 ` [PATCH v4 10/11] ARM: dts: AM33XX: Add PWM backlight DT data to am335x-evm Philip, Avinash
2012-11-22 21:11 ` Thierry Reding
2012-11-23 10:35 ` Philip, Avinash
2012-11-21 13:11 ` [PATCH v4 11/11] ARM: dts: AM33XX: Add PWM backlight DT data to am335x-evmsk Philip, Avinash
2012-11-22 21:12 ` Thierry Reding
2012-11-23 10:35 ` Philip, Avinash
2012-11-22 21:16 ` [PATCH v4 00/11] Support for AM33xx PWM Subsystem Thierry Reding
2012-11-23 10:42 ` Philip, Avinash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121122210347.GD16716@avionic-0098.adnet.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=anilkumar@ti.com \
--cc=avinashphilip@ti.com \
--cc=b-cousson@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=gururaja.hebbar@ti.com \
--cc=hvaibhav@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nsekhar@ti.com \
--cc=paul@pwsan.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=tony@atomide.com \
--cc=vaibhav.bedia@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome