From: Peter Korsgaard <jacmet@sunsite.dk>
To: Thierry Reding <thierry.reding@avionic-design.de>
Cc: "Philip\, Avinash" <avinashphilip@ti.com>,
"paul\@pwsan.com" <paul@pwsan.com>,
"tony\@atomide.com" <tony@atomide.com>,
"linux\@arm.linux.org.uk" <linux@arm.linux.org.uk>, "Cousson\,
Benoit" <b-cousson@ti.com>, "Hiremath\,
Vaibhav" <hvaibhav@ti.com>, "AnilKumar\,
Chimata" <anilkumar@ti.com>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree-discuss\@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"linux-doc\@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-omap\@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel\@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>, "Nori\,
Sekhar" <nsekhar@ti.com>, "Hebbar\,
Gururaja" <gururaja.hebbar@ti.com>, "Bedia\,
Vaibhav" <vaibhav.bedia@ti.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v4 05/11] pwm: pwm-tiecap: pinctrl support
Date: Fri, 23 Nov 2012 13:48:51 +0100 [thread overview]
Message-ID: <87mwy8eb7w.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20121123111811.GA5072@avionic-0098.adnet.avionic-design.de> (Thierry Reding's message of "Fri, 23 Nov 2012 12:18:11 +0100")
>>>>> "Thierry" == Thierry Reding <thierry.reding@avionic-design.de> writes:
Hi,
Thierry> Everybody seems to be doing it with a warning, so I guess
Thierry> that's fine for now. I just find it strange that if you
Thierry> request the default pin group to be selected when in fact the
Thierry> hardware doesn't support pinctrl at all you shouldn't be
Thierry> getting an error either.
There's several different situations:
- Platform without pinctrl support
- Platform with pinctrl support but no pinmux specified in dt for device
(E.G. pinmux setup in bootloader)
- Pinmux specified in dt
- Some kind of misconfiguration in dt
You could argue that devm_pinctrl_get_select_default() shouldn't return
an error for the first situation, but how should it be able to know the
difference between 2 and 4?
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2012-11-23 12:48 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 13:10 [PATCH v4 00/11] Support for AM33xx PWM Subsystem Philip, Avinash
2012-11-21 13:10 ` [PATCH v4 01/11] PWMSS: Add PWM Subsystem driver for parent<->child relationship Philip, Avinash
2012-11-22 20:47 ` Thierry Reding
2012-11-23 10:34 ` Philip, Avinash
2012-11-21 13:10 ` [PATCH v4 02/11] ARM: am33xx: clk: Add optional clock for EHRPWM Philip, Avinash
2012-11-21 13:11 ` [PATCH v4 03/11] ARM: OMAP: AM33xx hwmod: Add parent-child relationship for PWM subsystem Philip, Avinash
2012-11-21 13:11 ` [PATCH v4 04/11] pwm: pwm-tiecap: Add device-tree binding support for APWM driver Philip, Avinash
2012-11-22 20:57 ` Thierry Reding
2012-11-23 10:34 ` Philip, Avinash
2012-11-22 21:46 ` Thierry Reding
2012-11-21 13:11 ` [PATCH v4 05/11] pwm: pwm-tiecap: pinctrl support Philip, Avinash
2012-11-22 20:59 ` Thierry Reding
2012-11-23 10:34 ` Philip, Avinash
2012-11-23 10:51 ` Thierry Reding
2012-11-23 11:12 ` Philip, Avinash
2012-11-23 11:18 ` Thierry Reding
2012-11-23 12:48 ` Peter Korsgaard [this message]
2012-11-24 20:34 ` Thierry Reding
2012-11-27 14:20 ` Peter Korsgaard
2012-11-22 21:06 ` Thierry Reding
2012-11-21 13:11 ` [PATCH v4 06/11] pwm: pwm-tiehrpwm: Add device-tree binding support for EHRPWM driver Philip, Avinash
2012-11-22 21:03 ` Thierry Reding
2012-11-23 10:35 ` Philip, Avinash
2012-11-21 13:11 ` [PATCH v4 07/11] pwm: pwm-tiehrpwm: pinctrl support Philip, Avinash
2012-11-22 21:04 ` Thierry Reding
2012-11-21 13:11 ` [PATCH v4 08/11] pwm: pwm-tiehrpwm: Adding TBCLK gating support Philip, Avinash
2012-11-22 21:05 ` Thierry Reding
2012-11-21 13:11 ` [PATCH v4 09/11] ARM: dts: AM33XX: Add PWMSS device tree nodes Philip, Avinash
2012-11-22 21:08 ` Thierry Reding
2012-11-23 10:35 ` Philip, Avinash
2012-11-21 13:11 ` [PATCH v4 10/11] ARM: dts: AM33XX: Add PWM backlight DT data to am335x-evm Philip, Avinash
2012-11-22 21:11 ` Thierry Reding
2012-11-23 10:35 ` Philip, Avinash
2012-11-21 13:11 ` [PATCH v4 11/11] ARM: dts: AM33XX: Add PWM backlight DT data to am335x-evmsk Philip, Avinash
2012-11-22 21:12 ` Thierry Reding
2012-11-23 10:35 ` Philip, Avinash
2012-11-22 21:16 ` [PATCH v4 00/11] Support for AM33xx PWM Subsystem Thierry Reding
2012-11-23 10:42 ` Philip, Avinash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mwy8eb7w.fsf@dell.be.48ers.dk \
--to=jacmet@sunsite.dk \
--cc=anilkumar@ti.com \
--cc=avinashphilip@ti.com \
--cc=b-cousson@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=gururaja.hebbar@ti.com \
--cc=hvaibhav@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nsekhar@ti.com \
--cc=paul@pwsan.com \
--cc=thierry.reding@avionic-design.de \
--cc=tony@atomide.com \
--cc=vaibhav.bedia@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®