From: Jeff Layton <jlayton@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: Steve French <sfrench@samba.org>,
linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] cifs: Remove unused cEVENT macro
Date: Fri, 30 Nov 2012 06:47:10 -0500 [thread overview]
Message-ID: <20121130064710.1bcd227b@tlielax.poochiereds.net> (raw)
In-Reply-To: <7176cb20d420849d72aa004e40a404049362da7f.1354217746.git.joe@perches.com>
On Thu, 29 Nov 2012 11:37:18 -0800
Joe Perches <joe@perches.com> wrote:
> It uses an undefined KERN_EVENT and is itself unused.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> fs/cifs/cifs_debug.h | 7 -------
> 1 files changed, 0 insertions(+), 7 deletions(-)
>
> diff --git a/fs/cifs/cifs_debug.h b/fs/cifs/cifs_debug.h
> index c0c68bb..b0fc344 100644
> --- a/fs/cifs/cifs_debug.h
> +++ b/fs/cifs/cifs_debug.h
> @@ -63,12 +63,6 @@ do { \
> /* debug event message: */
> extern int cifsERROR;
>
> -#define cEVENT(fmt, arg...) \
> -do { \
> - if (cifsERROR) \
> - printk(KERN_EVENT "%s: " fmt "\n", __FILE__, ##arg); \
> -} while (0)
> -
> /* error event message: e.g., i/o error */
> #define cifserror(fmt, arg...) \
> do { \
> @@ -88,7 +82,6 @@ do { \
> */
> #else /* _CIFS_DEBUG */
> #define cERROR(set, fmt, arg...)
> -#define cEVENT(fmt, arg...)
> #define cFYI(set, fmt, arg...)
> #define cifserror(fmt, arg...)
> #endif /* _CIFS_DEBUG */
Yay! More cruft removal!
Reviewed-by: Jeff Layton <jlayton@redhat.com>
next prev parent reply other threads:[~2012-11-30 11:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 19:37 [PATCH 0/3] cifs: neatening and embedded module size reduction Joe Perches
2012-11-29 19:37 ` [PATCH 1/3] cifs: Remove unused cEVENT macro Joe Perches
2012-11-30 11:47 ` Jeff Layton [this message]
2012-11-30 15:39 ` Steve French
2012-12-03 18:46 ` Joe Perches
2012-12-04 18:18 ` Joe Perches
2012-11-29 19:37 ` [PATCH 2/3] cifs: Make CIFS_DEBUG possible to undefine Joe Perches
2012-11-30 11:49 ` Jeff Layton
2012-11-30 14:52 ` Joe Perches
2012-11-30 15:03 ` Jeff Layton
2012-11-29 19:37 ` [PATCH 3/3] cifs: Enable Kconfig control of CIFS_DEBUG Joe Perches
2012-11-30 11:56 ` Jeff Layton
2012-11-30 14:57 ` Joe Perches
2012-11-30 15:07 ` Jeff Layton
2012-11-30 15:31 ` [PATCH V2 3/3] cifs: Add CONFIG_CIFS_DEBUG and rename use " Joe Perches
2012-11-30 15:39 ` Jeff Layton
2012-11-30 15:42 ` [PATCH 3/3] cifs: Enable Kconfig control " Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121130064710.1bcd227b@tlielax.poochiereds.net \
--to=jlayton@redhat.com \
--cc=joe@perches.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®