From: Jeff Layton <jlayton@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: Steve French <sfrench@samba.org>,
linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] cifs: Make CIFS_DEBUG possible to undefine
Date: Fri, 30 Nov 2012 10:03:46 -0500 [thread overview]
Message-ID: <20121130100346.0aa9cabd@tlielax.poochiereds.net> (raw)
In-Reply-To: <1354287129.11903.3.camel@joe-AO722>
On Fri, 30 Nov 2012 06:52:09 -0800
Joe Perches <joe@perches.com> wrote:
> On Fri, 2012-11-30 at 06:49 -0500, Jeff Layton wrote:
> > On Thu, 29 Nov 2012 11:37:19 -0800
> > Joe Perches <joe@perches.com> wrote:
> >
> > > Make the compilation work again when CIFS_DEBUG is not #define'd.
> > >
> > > Add format and argument verification for the various macros when
> > > CIFS_DEBUG is not #define'd.
> []
> > Would it be better to simply make those the standard
> >
> > "do { ; } while(0)" noop macros?
> >
> > I'm not sure I see the point in keeping the printk statements in there...
>
> Actually, that's not standard.
> Look at printk.h
>
> It prevents developers from adding code that compiles
> without warnings in one mode but compiles with warnings
> in another.
>
> The idea is to make sure that format and arguments always
> match regardless of whether or not you are compiling
> debug or non-debug.
>
>
Fair enough then...
Reviewed-by: Jeff Layton <jlayton@redhat.com>
next prev parent reply other threads:[~2012-11-30 15:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 19:37 [PATCH 0/3] cifs: neatening and embedded module size reduction Joe Perches
2012-11-29 19:37 ` [PATCH 1/3] cifs: Remove unused cEVENT macro Joe Perches
2012-11-30 11:47 ` Jeff Layton
2012-11-30 15:39 ` Steve French
2012-12-03 18:46 ` Joe Perches
2012-12-04 18:18 ` Joe Perches
2012-11-29 19:37 ` [PATCH 2/3] cifs: Make CIFS_DEBUG possible to undefine Joe Perches
2012-11-30 11:49 ` Jeff Layton
2012-11-30 14:52 ` Joe Perches
2012-11-30 15:03 ` Jeff Layton [this message]
2012-11-29 19:37 ` [PATCH 3/3] cifs: Enable Kconfig control of CIFS_DEBUG Joe Perches
2012-11-30 11:56 ` Jeff Layton
2012-11-30 14:57 ` Joe Perches
2012-11-30 15:07 ` Jeff Layton
2012-11-30 15:31 ` [PATCH V2 3/3] cifs: Add CONFIG_CIFS_DEBUG and rename use " Joe Perches
2012-11-30 15:39 ` Jeff Layton
2012-11-30 15:42 ` [PATCH 3/3] cifs: Enable Kconfig control " Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121130100346.0aa9cabd@tlielax.poochiereds.net \
--to=jlayton@redhat.com \
--cc=joe@perches.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®