* [PATCH] spi: omap2-mcspi: Fix the redifine warning
@ 2012-11-19 6:42 Shubhrajyoti D
2012-11-19 10:33 ` Peter Korsgaard
2012-12-02 15:18 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Shubhrajyoti D @ 2012-11-19 6:42 UTC (permalink / raw)
To: spi-devel-general
Cc: broonie, grant.likely, linux-omap, linux-kernel, Shubhrajyoti D
Fix the below warning
drivers/spi/spi-omap2-mcspi.c:336:34: warning: symbol 'tx' shadows an earlier one
drivers/spi/spi-omap2-mcspi.c:327:12: originally declared here
So delete the u8 tx as it is assigned and not used(resigned afterwards).
Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
---
drivers/spi/spi-omap2-mcspi.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c
index 251f6d0..c3dcfb3 100644
--- a/drivers/spi/spi-omap2-mcspi.c
+++ b/drivers/spi/spi-omap2-mcspi.c
@@ -323,14 +323,11 @@ static void omap2_mcspi_tx_dma(struct spi_device *spi,
struct omap2_mcspi *mcspi;
struct omap2_mcspi_dma *mcspi_dma;
unsigned int count;
- const u8 * tx;
mcspi = spi_master_get_devdata(spi->master);
mcspi_dma = &mcspi->dma_channels[spi->chip_select];
count = xfer->len;
- tx = xfer->tx_buf;
-
if (mcspi_dma->dma_tx) {
struct dma_async_tx_descriptor *tx;
struct scatterlist sg;
--
1.7.5.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] spi: omap2-mcspi: Fix the redifine warning
2012-11-19 6:42 [PATCH] spi: omap2-mcspi: Fix the redifine warning Shubhrajyoti D
@ 2012-11-19 10:33 ` Peter Korsgaard
2012-12-02 15:18 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2012-11-19 10:33 UTC (permalink / raw)
To: Shubhrajyoti D; +Cc: spi-devel-general, linux-omap, broonie, linux-kernel
>>>>> "Shubhrajyoti" == Shubhrajyoti D <shubhrajyoti@ti.com> writes:
Shubhrajyoti> Fix the below warning
Shubhrajyoti> drivers/spi/spi-omap2-mcspi.c:336:34: warning: symbol
Shubhrajyoti> 'tx' shadows an earlier one
Shubhrajyoti> drivers/spi/spi-omap2-mcspi.c:327:12: originally declared
Shubhrajyoti> here
Shubhrajyoti> So delete the u8 tx as it is assigned and not
Shubhrajyoti> used(resigned afterwards).
Shubhrajyoti> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] spi: omap2-mcspi: Fix the redifine warning
2012-11-19 6:42 [PATCH] spi: omap2-mcspi: Fix the redifine warning Shubhrajyoti D
2012-11-19 10:33 ` Peter Korsgaard
@ 2012-12-02 15:18 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2012-12-02 15:18 UTC (permalink / raw)
To: Shubhrajyoti D; +Cc: spi-devel-general, grant.likely, linux-omap, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 255 bytes --]
On Mon, Nov 19, 2012 at 12:12:29PM +0530, Shubhrajyoti D wrote:
> Fix the below warning
> drivers/spi/spi-omap2-mcspi.c:336:34: warning: symbol 'tx' shadows an earlier one
> drivers/spi/spi-omap2-mcspi.c:327:12: originally declared here
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-12-02 15:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-19 6:42 [PATCH] spi: omap2-mcspi: Fix the redifine warning Shubhrajyoti D
2012-11-19 10:33 ` Peter Korsgaard
2012-12-02 15:18 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome