* [PATCH -next] drm: tegra: fix missing unlock on error
@ 2012-12-02 10:25 Wei Yongjun
2012-12-02 21:12 ` Thierry Reding
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2012-12-02 10:25 UTC (permalink / raw)
To: airlied, grant.likely, rob.herring, thierry.reding
Cc: yongjun_wei, dri-devel, devicetree-discuss, linux-tegra, linux-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Add the missing unlock before return from function host1x_drm_init()
and host1x_drm_exit() in the error handling case.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/gpu/drm/tegra/host1x.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/tegra/host1x.c b/drivers/gpu/drm/tegra/host1x.c
index bdb97a5..39629e6 100644
--- a/drivers/gpu/drm/tegra/host1x.c
+++ b/drivers/gpu/drm/tegra/host1x.c
@@ -176,6 +176,7 @@ int host1x_drm_init(struct host1x *host1x, struct drm_device *drm)
dev_err(host1x->dev,
"DRM setup failed for %s: %d\n",
dev_name(client->dev), err);
+ mutex_unlock(&host1x->clients_lock);
return err;
}
}
@@ -203,6 +204,7 @@ int host1x_drm_exit(struct host1x *host1x)
dev_err(host1x->dev,
"DRM cleanup failed for %s: %d\n",
dev_name(client->dev), err);
+ mutex_unlock(&host1x->clients_lock);
return err;
}
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] drm: tegra: fix missing unlock on error
2012-12-02 10:25 [PATCH -next] drm: tegra: fix missing unlock on error Wei Yongjun
@ 2012-12-02 21:12 ` Thierry Reding
0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2012-12-02 21:12 UTC (permalink / raw)
To: Wei Yongjun
Cc: airlied, grant.likely, rob.herring, yongjun_wei, dri-devel,
devicetree-discuss, linux-tegra, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1195 bytes --]
On Sun, Dec 02, 2012 at 05:25:05AM -0500, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Add the missing unlock before return from function host1x_drm_init()
> and host1x_drm_exit() in the error handling case.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/gpu/drm/tegra/host1x.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/tegra/host1x.c b/drivers/gpu/drm/tegra/host1x.c
> index bdb97a5..39629e6 100644
> --- a/drivers/gpu/drm/tegra/host1x.c
> +++ b/drivers/gpu/drm/tegra/host1x.c
> @@ -176,6 +176,7 @@ int host1x_drm_init(struct host1x *host1x, struct drm_device *drm)
> dev_err(host1x->dev,
> "DRM setup failed for %s: %d\n",
> dev_name(client->dev), err);
> + mutex_unlock(&host1x->clients_lock);
> return err;
> }
> }
> @@ -203,6 +204,7 @@ int host1x_drm_exit(struct host1x *host1x)
> dev_err(host1x->dev,
> "DRM cleanup failed for %s: %d\n",
> dev_name(client->dev), err);
> + mutex_unlock(&host1x->clients_lock);
> return err;
> }
> }
Acked-by: Thierry Reding <thierry.reding@avionic-design.de>
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-02 21:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-02 10:25 [PATCH -next] drm: tegra: fix missing unlock on error Wei Yongjun
2012-12-02 21:12 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome