* watchdog: del_timer call missing on the cpu5wdt.c
@ 2012-06-26 9:18 devendra.aaru
2012-12-12 20:18 ` Wim Van Sebroeck
0 siblings, 1 reply; 2+ messages in thread
From: devendra.aaru @ 2012-06-26 9:18 UTC (permalink / raw)
To: Wim Van Sebroeck, linux-watchdog, linux-kernel
Hi,
We do a setup_timer at init stage of the module, but we didn't
de-activate the time using del_timer.
The below patch may help doing so..
Please feel free to comment...
diff --git a/drivers/watchdog/cpu5wdt.c b/drivers/watchdog/cpu5wdt.c
index 7e88839..fca50a7 100644
--- a/drivers/watchdog/cpu5wdt.c
+++ b/drivers/watchdog/cpu5wdt.c
@@ -266,6 +266,7 @@ static void __devexit cpu5wdt_exit(void)
if (cpu5wdt_device.queue) {
cpu5wdt_device.queue = 0;
wait_for_completion(&cpu5wdt_device.stop);
+ del_timer(&cpu5wdt_device.timer);
}
Thanks,
Devendra.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: watchdog: del_timer call missing on the cpu5wdt.c
2012-06-26 9:18 watchdog: del_timer call missing on the cpu5wdt.c devendra.aaru
@ 2012-12-12 20:18 ` Wim Van Sebroeck
0 siblings, 0 replies; 2+ messages in thread
From: Wim Van Sebroeck @ 2012-12-12 20:18 UTC (permalink / raw)
To: devendra.aaru; +Cc: linux-watchdog, linux-kernel
Hi,
> We do a setup_timer at init stage of the module, but we didn't
> de-activate the time using del_timer.
Added to linux-watchdog-next.
Kind regards,
Wim.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-12 20:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-26 9:18 watchdog: del_timer call missing on the cpu5wdt.c devendra.aaru
2012-12-12 20:18 ` Wim Van Sebroeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome