From: Thierry Reding <thierry.reding@avionic-design.de>
To: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
kgene.kim@samsung.com, kyungmin.park@samsung.com
Subject: Re: [PATCH] pwm: samsung: add missing s3c->pwm_id
Date: Fri, 14 Dec 2012 07:52:01 +0100 [thread overview]
Message-ID: <20121214065200.GB24094@avionic-0098.adnet.avionic-design.de> (raw)
In-Reply-To: <1355458809-12290-1-git-send-email-jy0922.shim@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 818 bytes --]
On Fri, Dec 14, 2012 at 01:20:09PM +0900, Joonyoung Shim wrote:
> The s3c->pwm_id is used to calculate offset of related register.
>
> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
> ---
> drivers/pwm/pwm-samsung.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c
> index 023a3be..b415102 100644
> --- a/drivers/pwm/pwm-samsung.c
> +++ b/drivers/pwm/pwm-samsung.c
> @@ -220,6 +220,8 @@ static int s3c_pwm_probe(struct platform_device *pdev)
> return -ENOMEM;
> }
>
> + s3c->pwm_id = id;
> +
> /* calculate base of control bits in TCON */
> s3c->tcon_base = id == 0 ? 0 : (id * 4) + 4;
Can you please move the assignment to below the above line? That way s3c
initialization is more localized.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-12-14 6:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-14 4:20 Joonyoung Shim
2012-12-14 6:52 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121214065200.GB24094@avionic-0098.adnet.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=jy0922.shim@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome