* [PATCH] pwm: samsung: add missing s3c->pwm_id
@ 2012-12-14 4:20 Joonyoung Shim
2012-12-14 6:52 ` Thierry Reding
0 siblings, 1 reply; 2+ messages in thread
From: Joonyoung Shim @ 2012-12-14 4:20 UTC (permalink / raw)
To: thierry.reding; +Cc: linux-samsung-soc, linux-kernel, kgene.kim, kyungmin.park
The s3c->pwm_id is used to calculate offset of related register.
Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
---
drivers/pwm/pwm-samsung.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c
index 023a3be..b415102 100644
--- a/drivers/pwm/pwm-samsung.c
+++ b/drivers/pwm/pwm-samsung.c
@@ -220,6 +220,8 @@ static int s3c_pwm_probe(struct platform_device *pdev)
return -ENOMEM;
}
+ s3c->pwm_id = id;
+
/* calculate base of control bits in TCON */
s3c->tcon_base = id == 0 ? 0 : (id * 4) + 4;
s3c->chip.dev = &pdev->dev;
--
1.7.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] pwm: samsung: add missing s3c->pwm_id
2012-12-14 4:20 [PATCH] pwm: samsung: add missing s3c->pwm_id Joonyoung Shim
@ 2012-12-14 6:52 ` Thierry Reding
0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2012-12-14 6:52 UTC (permalink / raw)
To: Joonyoung Shim; +Cc: linux-samsung-soc, linux-kernel, kgene.kim, kyungmin.park
[-- Attachment #1: Type: text/plain, Size: 818 bytes --]
On Fri, Dec 14, 2012 at 01:20:09PM +0900, Joonyoung Shim wrote:
> The s3c->pwm_id is used to calculate offset of related register.
>
> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
> ---
> drivers/pwm/pwm-samsung.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c
> index 023a3be..b415102 100644
> --- a/drivers/pwm/pwm-samsung.c
> +++ b/drivers/pwm/pwm-samsung.c
> @@ -220,6 +220,8 @@ static int s3c_pwm_probe(struct platform_device *pdev)
> return -ENOMEM;
> }
>
> + s3c->pwm_id = id;
> +
> /* calculate base of control bits in TCON */
> s3c->tcon_base = id == 0 ? 0 : (id * 4) + 4;
Can you please move the assignment to below the above line? That way s3c
initialization is more localized.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-14 6:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-14 4:20 [PATCH] pwm: samsung: add missing s3c->pwm_id Joonyoung Shim
2012-12-14 6:52 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome