From: Jean Delvare <khali@linux-fr.org>
To: Vinod Koul <vinod.koul@linux.intel.com>, Dan Williams <djbw@fb.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dma: ipu: Drop unused spinlock
Date: Sun, 16 Dec 2012 21:40:06 +0100 [thread overview]
Message-ID: <20121216214006.29f3152c@endymion.delvare> (raw)
In-Reply-To: <1347592212.1943.15.camel@vkoul-udesk3>
On Fri, 14 Sep 2012 08:40:12 +0530, Vinod Koul wrote:
> On Thu, 2012-09-06 at 09:19 +0200, Jean Delvare wrote:
> > I was checking why this spinlock was never initialized, but it turns
> > out it's not used anywhere, so we can drop it.
> >
> > Signed-off-by: Jean Delvare <khali@linux-fr.org>
> > Cc: Vinod Koul <vinod.koul@intel.com>
> > Cc: Dan Williams <djbw@fb.com>
> > ---
> > I can't even build-test this.
> >
> > drivers/dma/ipu/ipu_irq.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > --- linux-3.6-rc4.orig/drivers/dma/ipu/ipu_irq.c 2012-08-04 21:49:26.000000000 +0200
> > +++ linux-3.6-rc4/drivers/dma/ipu/ipu_irq.c 2012-09-06 09:13:31.034228670 +0200
> > @@ -45,7 +45,6 @@ static void ipu_write_reg(struct ipu *ip
> > struct ipu_irq_bank {
> > unsigned int control;
> > unsigned int status;
> > - spinlock_t lock;
> > struct ipu *ipu;
> > };
>
> Dan, you okay with this?
What happened to this patch? Dan, please?
--
Jean Delvare
prev parent reply other threads:[~2012-12-16 20:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 7:19 Jean Delvare
2012-09-14 3:10 ` Vinod Koul
2012-12-16 20:40 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121216214006.29f3152c@endymion.delvare \
--to=khali@linux-fr.org \
--cc=djbw@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®