* [PATCH] dma: ipu: Drop unused spinlock
@ 2012-09-06 7:19 Jean Delvare
2012-09-14 3:10 ` Vinod Koul
0 siblings, 1 reply; 3+ messages in thread
From: Jean Delvare @ 2012-09-06 7:19 UTC (permalink / raw)
To: LKML; +Cc: Vinod Koul, Dan Williams
I was checking why this spinlock was never initialized, but it turns
out it's not used anywhere, so we can drop it.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: Dan Williams <djbw@fb.com>
---
I can't even build-test this.
drivers/dma/ipu/ipu_irq.c | 1 -
1 file changed, 1 deletion(-)
--- linux-3.6-rc4.orig/drivers/dma/ipu/ipu_irq.c 2012-08-04 21:49:26.000000000 +0200
+++ linux-3.6-rc4/drivers/dma/ipu/ipu_irq.c 2012-09-06 09:13:31.034228670 +0200
@@ -45,7 +45,6 @@ static void ipu_write_reg(struct ipu *ip
struct ipu_irq_bank {
unsigned int control;
unsigned int status;
- spinlock_t lock;
struct ipu *ipu;
};
--
Jean Delvare
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dma: ipu: Drop unused spinlock
2012-09-06 7:19 [PATCH] dma: ipu: Drop unused spinlock Jean Delvare
@ 2012-09-14 3:10 ` Vinod Koul
2012-12-16 20:40 ` Jean Delvare
0 siblings, 1 reply; 3+ messages in thread
From: Vinod Koul @ 2012-09-14 3:10 UTC (permalink / raw)
To: Dan Williams; +Cc: LKML, Jean Delvare
On Thu, 2012-09-06 at 09:19 +0200, Jean Delvare wrote:
> I was checking why this spinlock was never initialized, but it turns
> out it's not used anywhere, so we can drop it.
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Cc: Vinod Koul <vinod.koul@intel.com>
> Cc: Dan Williams <djbw@fb.com>
> ---
> I can't even build-test this.
>
> drivers/dma/ipu/ipu_irq.c | 1 -
> 1 file changed, 1 deletion(-)
>
> --- linux-3.6-rc4.orig/drivers/dma/ipu/ipu_irq.c 2012-08-04 21:49:26.000000000 +0200
> +++ linux-3.6-rc4/drivers/dma/ipu/ipu_irq.c 2012-09-06 09:13:31.034228670 +0200
> @@ -45,7 +45,6 @@ static void ipu_write_reg(struct ipu *ip
> struct ipu_irq_bank {
> unsigned int control;
> unsigned int status;
> - spinlock_t lock;
> struct ipu *ipu;
> };
>
Dan, you okay with this?
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dma: ipu: Drop unused spinlock
2012-09-14 3:10 ` Vinod Koul
@ 2012-12-16 20:40 ` Jean Delvare
0 siblings, 0 replies; 3+ messages in thread
From: Jean Delvare @ 2012-12-16 20:40 UTC (permalink / raw)
To: Vinod Koul, Dan Williams; +Cc: LKML
On Fri, 14 Sep 2012 08:40:12 +0530, Vinod Koul wrote:
> On Thu, 2012-09-06 at 09:19 +0200, Jean Delvare wrote:
> > I was checking why this spinlock was never initialized, but it turns
> > out it's not used anywhere, so we can drop it.
> >
> > Signed-off-by: Jean Delvare <khali@linux-fr.org>
> > Cc: Vinod Koul <vinod.koul@intel.com>
> > Cc: Dan Williams <djbw@fb.com>
> > ---
> > I can't even build-test this.
> >
> > drivers/dma/ipu/ipu_irq.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > --- linux-3.6-rc4.orig/drivers/dma/ipu/ipu_irq.c 2012-08-04 21:49:26.000000000 +0200
> > +++ linux-3.6-rc4/drivers/dma/ipu/ipu_irq.c 2012-09-06 09:13:31.034228670 +0200
> > @@ -45,7 +45,6 @@ static void ipu_write_reg(struct ipu *ip
> > struct ipu_irq_bank {
> > unsigned int control;
> > unsigned int status;
> > - spinlock_t lock;
> > struct ipu *ipu;
> > };
>
> Dan, you okay with this?
What happened to this patch? Dan, please?
--
Jean Delvare
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-12-16 20:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-06 7:19 [PATCH] dma: ipu: Drop unused spinlock Jean Delvare
2012-09-14 3:10 ` Vinod Koul
2012-12-16 20:40 ` Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®