From: David Howells <dhowells@redhat.com>
To: torvalds@linux-foundation.com
Cc: linux-security-module@vger.kernel.org,
Alan Cox <alan@linux.intel.com>,
jmorris@namei.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] keys: Fix unreachable code
Date: Mon, 17 Dec 2012 13:15:23 +0000 [thread overview]
Message-ID: <20121217131523.2974.74337.stgit@warthog.procyon.org.uk> (raw)
From: Alan Cox <alan@linux.intel.com>
We set ret to NULL then test it. Remove the bogus test
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: David Howells <dhowells@redhat.com>
---
security/keys/process_keys.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/security/keys/process_keys.c b/security/keys/process_keys.c
index 58dfe08..20e4bf5 100644
--- a/security/keys/process_keys.c
+++ b/security/keys/process_keys.c
@@ -367,8 +367,6 @@ key_ref_t search_my_process_keyrings(struct key_type *type,
switch (PTR_ERR(key_ref)) {
case -EAGAIN: /* no key */
- if (ret)
- break;
case -ENOKEY: /* negative key */
ret = key_ref;
break;
next reply other threads:[~2012-12-17 13:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 13:15 David Howells [this message]
2012-12-17 13:15 ` [PATCH 2/2] KEYS: Use keyring_alloc() to create module signing keyring David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121217131523.2974.74337.stgit@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=alan@linux.intel.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=torvalds@linux-foundation.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®