From: Thierry Reding <thierry.reding@avionic-design.de>
To: Jesper Nilsson <jesper.nilsson@axis.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Alessandro Zummo <a.zummo@towertech.it>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc-pcf8523: Add low battery voltage support
Date: Wed, 19 Dec 2012 16:19:37 +0100 [thread overview]
Message-ID: <20121219151937.GA21212@avionic-0098.adnet.avionic-design.de> (raw)
In-Reply-To: <20121219151054.GB14217@axis.com>
[-- Attachment #1: Type: text/plain, Size: 757 bytes --]
On Wed, Dec 19, 2012 at 04:10:54PM +0100, Jesper Nilsson wrote:
> On Wed, Dec 19, 2012 at 03:42:26PM +0100, Thierry Reding wrote:
> > On Wed, Dec 19, 2012 at 03:04:56PM +0100, Jesper Nilsson wrote:
[...]
> > > + .read_vl = pcf8523_rtc_read_vl,
> >
> > What tree is this based on? None of the trees I have contains .read_vl
> > in rtc_class_ops.
>
> Hm, I've tested this against a local 3.4 kernel since that is what my
> device had, I didn't realize that we already had some local changes for
> the voltage low stuff.
>
> I'm guessing the right way is to do it as the pcf8563 in the mainline kernel,
> I'll respin my patch and resend.
From a quick search through the mainline kernel history, there's no
trace of this field.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-12-19 15:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-19 14:04 Jesper Nilsson
2012-12-19 14:42 ` Thierry Reding
2012-12-19 15:10 ` Jesper Nilsson
2012-12-19 15:19 ` Thierry Reding [this message]
2012-12-19 15:34 ` [PATCH v2] " Jesper Nilsson
2012-12-19 15:48 ` Thierry Reding
2012-12-19 16:00 ` [PATCH v3] " Jesper Nilsson
2012-12-19 22:03 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121219151937.GA21212@avionic-0098.adnet.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=jesper.nilsson@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome