mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Corey Ashford <cjashfor@linux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@elte.hu>, Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 3/3] perf tool: Add non arch events for SandyBridge microarchitecture
Date: Thu, 20 Dec 2012 12:13:13 +0100	[thread overview]
Message-ID: <20121220111313.GB1241@krava.brq.redhat.com> (raw)
In-Reply-To: <m2zk19d7vk.fsf@firstfloor.org>

On Wed, Dec 19, 2012 at 01:55:43PM -0800, Andi Kleen wrote:
> Jiri Olsa <jolsa@redhat.com> writes:
> 
> > Adding non architectural event aliases for Sandy Bridge
> > microarchitecture.
> 
> "SandyBridge" is not necessarily unique. There are flavours
> of sandy bridge with slightly different events (e.g. in offcore)
> Also there's uncores too, which are very different between
> different SandyBridges.
> 
> I would merge all these little files into a single file.
> I don't think anyone wants hundreds of new files for this, 
> if you do it for multiple CPUs.

right, that's better

> 
> Besides it would waste insane amounts of space on most file systems
> without tail packing -- each of your little files takes 4K plus an inode
> and directory entry.
> 
> Intel normally uses a spreadsheet CSV format.

Is there anything in public I could download and check?

> 
> Best would be probably to just teach perf about reading one of those
> standard formats, then they could be just downloaded somewhere.

so, when you say standard format.. CSV? like:

BR_MISP_EXEC.ALL_BRANCHES,event=0x89,umask=0xff
BR_MISP_EXEC.COND,event=0x89,umask=0x1
BR_MISP_EXEC.DIRECT_NEAR_CALL,event=0x89,umask=0x10
BR_MISP_EXEC.INDIRECT_JMP_NON_CALL_RET,event=0x89,umask=0x4
BR_MISP_EXEC.INDIRECT_NEAR_CALL,event=0x89,umask=0x20
BR_MISP_EXEC.NONTAKEN,event=0x89,umask=0x40
BR_MISP_EXEC.RETURN_NEAR,event=0x89,umask=0x8
BR_MISP_EXEC.TAKEN,event=0x89,umask=0x80

would be no big change for alias loader

thanks,
jirka

  reply	other threads:[~2012-12-20 11:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-17 13:37 [RFC 0/3] perf tool: Add non-architectural event aliases Jiri Olsa
2012-12-17 13:37 ` [PATCH 1/3] perf tool: Add '.' as part of the event 'name' token Jiri Olsa
2012-12-17 13:37 ` [PATCH 2/3] perf tool: Add support to include non architectural event aliases Jiri Olsa
2012-12-18  1:12   ` Namhyung Kim
2012-12-18  7:41     ` Jiri Olsa
2012-12-17 13:37 ` [PATCH 3/3] perf tool: Add non arch events for SandyBridge microarchitecture Jiri Olsa
2012-12-19 21:55   ` Andi Kleen
2012-12-20 11:13     ` Jiri Olsa [this message]
2012-12-21 18:07       ` Vince Weaver
2012-12-21 18:43         ` Andi Kleen
2012-12-22  1:58           ` Vince Weaver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121220111313.GB1241@krava.brq.redhat.com \
    --to=jolsa@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=andi@firstfloor.org \
    --cc=cjashfor@linux.vnet.ibm.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=namhyung@kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome