Re: [PATCH 2/3] perf tool: Add support to include non architectural event aliases

[Namhyung Kim <namhyung@kernel.org>]

Hi Jiri,

On Mon, 17 Dec 2012 14:37:04 +0100, Jiri Olsa wrote:
> Adding support to parse non architectural event aliases
> for given cpu. These aliases will be provided as 'events'
> directory like architectural ones provided by kernel.
>
[snip]
> +
> +$(OUTPUT)$(OUTPUT)arch/$(ARCH)/util/pmu.o: $(OUTPUT)arch/$(ARCH)/util/pmu.c $(OUTPUT)PERF-CFLAGS

Double OUTPUT ? ;)


> +	$(QUIET_CC)$(CC) -o $@ -c $(ALL_CFLAGS) \
> +	 '-DPERF_EXEC_PATH="$(perfexecdir_SQ)"' \
> +	 '-DPREFIX="$(prefix_SQ)"' \
> +	 $<
[snip]
> +static int cpu_aliases(struct list_head *head)
> +{
> +	unsigned vendol, model;

s/vendol/vendor/ ?

Thanks,
Namhyung


> +	int ret;
> +
> +	ret = cpu_specs(&vendol, &model);
> +	if (ret) {
> +		pr_info("failed to get cpu aliases");
> +		return 0;
> +	}
> +
> +	switch (vendol) {
> +	/* Intel */
> +	case 0:
> +		return intel_aliases(head, model);
> +	default:
> +		/* unknown vendor.. plenty to cover ;-) */
> +		return 0;
> +	}
> +
> +	return 0;
> +}