From: Arnd Bergmann <arnd@arndb.de>
To: Alan Cox <alan@linux.intel.com>
Cc: arve@android.com, x86@kernel.org, linux-kernel@vger.kernel.org,
mikechan@google.com
Subject: Re: [PATCH 03/10] goldfish: tty driver
Date: Wed, 9 Jan 2013 22:33:09 +0000 [thread overview]
Message-ID: <201301092233.10166.arnd@arndb.de> (raw)
In-Reply-To: <20130109142318.9239.14079.stgit@bob.linux.org.uk>
On Wednesday 09 January 2013, Alan Cox wrote:
> +static int __devinit goldfish_tty_probe(struct platform_device *pdev)
> +{
> + struct goldfish_tty *qtty;
> ...
> +
> +static int __init goldfish_tty_init(void)
> +{
> + return platform_driver_register(&goldfish_tty_platform_driver);
> +}
> +
> +static void __exit goldfish_tty_exit(void)
> +{
> + platform_driver_unregister(&goldfish_tty_platform_driver);
> +}
> +
> +module_init(goldfish_tty_init);
> +module_exit(goldfish_tty_exit);
The same comments on __devinit/__devexit and module_platform_driver
that I made on the bus driver apparently apply on this patch and
some of the others.
Arnd
next prev parent reply other threads:[~2013-01-09 22:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-09 14:22 [PATCH 00/10] goldfish: rebase/resend versus current -next Alan Cox
2013-01-09 14:22 ` [PATCH 01/10] goldfish: definitions for Goldfish on x86 platforms Alan Cox
2013-01-09 14:23 ` [PATCH 02/10] goldfish: add the goldfish virtual bus Alan Cox
2013-01-09 22:30 ` Arnd Bergmann
2013-01-10 15:54 ` Alan Cox
2013-01-09 14:23 ` [PATCH 03/10] goldfish: tty driver Alan Cox
2013-01-09 22:33 ` Arnd Bergmann [this message]
2013-01-09 14:24 ` [PATCH 04/10] goldfish: virtual input event driver Alan Cox
2013-01-09 14:24 ` [PATCH 05/10] goldfish: framebuffer Alan Cox
2013-01-09 14:24 ` [PATCH 06/10] goldfish: emulated MMC device Alan Cox
2013-01-09 14:25 ` [PATCH 07/10] goldfish: power device Alan Cox
2013-01-09 14:25 ` [PATCH 08/10] goldfish: real time clock Alan Cox
2013-01-09 14:25 ` [PATCH 09/10] goldfish: add QEMU pipe driver Alan Cox
2013-01-09 14:26 ` [PATCH 10/10] goldfish: NAND flash driver Alan Cox
2014-03-10 15:39 ` [PATCH 00/10] goldfish: rebase/resend versus current -next Guennadi Liakhovetski
2013-01-16 16:58 [PATCH 00/10] goldfish: still swimming Alan Cox
2013-01-16 16:59 ` [PATCH 03/10] goldfish: tty driver Alan Cox
2013-01-16 17:01 ` Felipe Balbi
2013-01-16 18:25 ` Alan Cox
2013-01-17 8:41 ` Felipe Balbi
2013-01-17 17:53 [PATCH 00/10] goldish: onwards, upwards 8) Alan Cox
2013-01-17 17:54 ` [PATCH 03/10] goldfish: tty driver Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201301092233.10166.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=alan@linux.intel.com \
--cc=arve@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikechan@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome