From: Felipe Balbi <balbi@ti.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: <balbi@ti.com>, Alan Cox <alan@linux.intel.com>,
<arve@android.com>, <x86@kernel.org>,
<linux-kernel@vger.kernel.org>, <mikechan@google.com>
Subject: Re: [PATCH 03/10] goldfish: tty driver
Date: Thu, 17 Jan 2013 10:41:36 +0200 [thread overview]
Message-ID: <20130117084136.GC10814@arwen.pp.htv.fi> (raw)
In-Reply-To: <20130116182520.64b1fe6a@pyramind.ukuu.org.uk>
[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]
Hi,
On Wed, Jan 16, 2013 at 06:25:20PM +0000, Alan Cox wrote:
> On Wed, 16 Jan 2013 19:01:22 +0200
> Felipe Balbi <balbi@ti.com> wrote:
>
> > Hi,
> >
> > On Wed, Jan 16, 2013 at 04:59:03PM +0000, Alan Cox wrote:
> > > +static int goldfish_tty_probe(struct platform_device *pdev)
> > > +{
> > > + struct goldfish_tty *qtty;
> > > + int ret = -EINVAL;
> > > + int i;
> > > + struct resource *r;
> > > + struct device *ttydev;
> > > + void __iomem *base;
> > > + u32 irq;
> > > +
> > > + r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > > + if(r == NULL)
> > > + return -EINVAL;
> > > +
> > > + base = ioremap(r->start, 0x1000);
> >
> > missing request_mem_region(), in fact you could just use
> > devm_request_and_ioremap().
>
> Actually the reservation is already done by the bus driver. If it sees
> the goldfish interface it reserves the entire chunk and the emulator then
> tells it which is in each chunk of that range.
a bit unusual, but fair enough.
cheers
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-01-17 8:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 16:58 [PATCH 00/10] goldfish: still swimming Alan Cox
2013-01-16 16:58 ` [PATCH 01/10] goldfish: definitions for Goldfish on x86 platforms Alan Cox
2013-01-16 16:58 ` [PATCH 02/10] goldfish: add the goldfish virtual bus Alan Cox
2013-01-16 16:57 ` Felipe Balbi
2013-01-16 16:59 ` [PATCH 03/10] goldfish: tty driver Alan Cox
2013-01-16 17:01 ` Felipe Balbi
2013-01-16 18:25 ` Alan Cox
2013-01-17 8:41 ` Felipe Balbi [this message]
2013-01-16 16:59 ` [PATCH 04/10] goldfish: virtual input event driver Alan Cox
2013-01-16 17:13 ` Felipe Balbi
2013-01-16 16:59 ` [PATCH 05/10] goldfish: framebuffer Alan Cox
2013-01-16 16:59 ` [PATCH 06/10] goldfish: emulated MMC device Alan Cox
2013-01-16 17:18 ` Felipe Balbi
2013-01-16 17:27 ` Alan Cox
2013-01-16 17:26 ` Felipe Balbi
2013-01-16 16:59 ` [PATCH 07/10] goldfish: power device Alan Cox
2013-01-16 17:00 ` [PATCH 08/10] goldfish: real time clock Alan Cox
2013-01-16 17:00 ` [PATCH 09/10] goldfish: add QEMU pipe driver Alan Cox
2013-01-16 17:00 ` [PATCH 10/10] goldfish: NAND flash driver Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2013-01-17 17:53 [PATCH 00/10] goldish: onwards, upwards 8) Alan Cox
2013-01-17 17:54 ` [PATCH 03/10] goldfish: tty driver Alan Cox
2013-01-09 14:22 [PATCH 00/10] goldfish: rebase/resend versus current -next Alan Cox
2013-01-09 14:23 ` [PATCH 03/10] goldfish: tty driver Alan Cox
2013-01-09 22:33 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130117084136.GC10814@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=alan@linux.intel.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arve@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikechan@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®