From: Jeff Layton <jlayton@redhat.com>
To: Nickolai Zeldovich <nickolai@csail.mit.edu>
Cc: Steve French <sfrench@samba.org>,
linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cifs: fix srcip_matches() for ipv6
Date: Thu, 17 Jan 2013 11:24:12 -0500 [thread overview]
Message-ID: <20130117112412.095f7aef@corrin.poochiereds.net> (raw)
In-Reply-To: <1358390177-24422-1-git-send-email-nickolai@csail.mit.edu>
On Wed, 16 Jan 2013 21:36:17 -0500
Nickolai Zeldovich <nickolai@csail.mit.edu> wrote:
> srcip_matches() previously had code like this:
>
> srcip_matches(..., struct sockaddr *rhs) {
> /* ... */
> struct sockaddr_in6 *vaddr6 = (struct sockaddr_in6 *) &rhs;
> return ipv6_addr_equal(..., &vaddr6->sin6_addr);
> }
>
> which interpreted the values on the stack after the 'rhs' pointer as an
> ipv6 address. The correct thing to do is to use 'rhs', not '&rhs'.
>
> Signed-off-by: Nickolai Zeldovich <nickolai@csail.mit.edu>
> ---
> fs/cifs/connect.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index 17c3643..12b3da3 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
> @@ -1917,7 +1917,7 @@ srcip_matches(struct sockaddr *srcaddr, struct sockaddr *rhs)
> }
> case AF_INET6: {
> struct sockaddr_in6 *saddr6 = (struct sockaddr_in6 *)srcaddr;
> - struct sockaddr_in6 *vaddr6 = (struct sockaddr_in6 *)&rhs;
> + struct sockaddr_in6 *vaddr6 = (struct sockaddr_in6 *)rhs;
> return ipv6_addr_equal(&saddr6->sin6_addr, &vaddr6->sin6_addr);
> }
> default:
Nice catch...
Reviewed-by: Jeff Layton <jlayton@redhat.com>
prev parent reply other threads:[~2013-01-17 16:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-17 2:36 Nickolai Zeldovich
2013-01-17 3:51 ` Steve French
2013-01-17 4:04 ` Nickolai Zeldovich
2013-01-21 7:41 ` Steve French
2013-01-17 16:24 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130117112412.095f7aef@corrin.poochiereds.net \
--to=jlayton@redhat.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nickolai@csail.mit.edu \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®