From: "J. Bruce Fields" <bfields@fieldses.org>
To: Mark Lord <kernel@teksavvy.com>
Cc: linux-nfs@vger.kernel.org, Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: BUG at net/sunrpc/svc_xprt.c:921
Date: Thu, 17 Jan 2013 08:53:33 -0500 [thread overview]
Message-ID: <20130117135333.GF6598@fieldses.org> (raw)
In-Reply-To: <50F7F898.5050605@teksavvy.com>
On Thu, Jan 17, 2013 at 08:11:52AM -0500, Mark Lord wrote:
> On 13-01-14 11:17 AM, Mark Lord wrote:
> >
> > Here's the code with the BUG() at net/sunrpc/svc_xprt.c line 921:
> >
> > /*
> > * Remove a dead transport
> > */
> > static void svc_delete_xprt(struct svc_xprt *xprt)
> > {
> > struct svc_serv *serv = xprt->xpt_server;
> > struct svc_deferred_req *dr;
> >
> > /* Only do this once */
> > if (test_and_set_bit(XPT_DEAD, &xprt->xpt_flags))
> > BUG();
>
>
> Shouldn't there also be a return statement after the BUG() line,
> inside the if-stmt ?
BUG() kills the thread that calls it, so it never returns, and a
following statement wouldn't be executed--I may not understand your
question.
--b.
>
> I mean, the comment says "only do this once", but it actually
> appears to end up doing it twice, despite the test.
>
> ??
next prev parent reply other threads:[~2013-01-17 13:53 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 16:17 Mark Lord
2013-01-14 20:37 ` J. Bruce Fields
2013-01-15 4:16 ` Mark Lord
2013-01-15 20:56 ` J. Bruce Fields
2013-01-16 5:20 ` Stanislav Kinsbursky
2013-01-16 22:51 ` Mark Lord
2013-01-16 22:58 ` Mark Lord
2013-01-17 5:05 ` Stanislav Kinsbursky
2013-01-17 13:03 ` J. Bruce Fields
2013-01-17 13:24 ` Stanislav Kinsbursky
2013-01-17 23:41 ` Mark Lord
2013-01-18 5:37 ` Stanislav Kinsbursky
2013-01-18 15:48 ` Mark Lord
2013-01-18 15:56 ` J. Bruce Fields
2013-01-21 8:19 ` Stanislav Kinsbursky
2013-01-20 22:51 ` BUG at net/sunrpc/svc_xprt.c:921 (another one) Mark Lord
2013-02-12 20:52 ` J. Bruce Fields
2013-02-13 15:00 ` Mark Lord
2013-02-15 19:22 ` J. Bruce Fields
2013-02-15 19:42 ` Tom Horsley
2013-02-15 19:46 ` J. Bruce Fields
2013-02-15 19:23 ` [PATCH 1/2] svcrpc: make svc_age_temp_xprts enqueue under sv_lock J. Bruce Fields
2013-02-15 19:23 ` [PATCH 2/2] svcrpc: fix rpc server shutdown races J. Bruce Fields
2013-02-15 19:33 ` BUG at net/sunrpc/svc_xprt.c:921 (another one) Paweł Sikora
2013-02-17 15:54 ` J. Bruce Fields
2013-02-18 7:42 ` Paweł Sikora
2013-01-17 13:11 ` BUG at net/sunrpc/svc_xprt.c:921 Mark Lord
2013-01-17 13:53 ` J. Bruce Fields [this message]
2013-01-17 23:40 ` Mark Lord
2013-02-25 20:45 ` Mark Lord
2013-02-25 20:52 ` J. Bruce Fields
2013-02-07 12:56 Tom Horsley
2013-02-08 20:58 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130117135333.GF6598@fieldses.org \
--to=bfields@fieldses.org \
--cc=kernel@teksavvy.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome