[patch v1 3/5] hwmon: da9055 change irq state to default

[patch v1 3/5] hwmon: da9055 change irq state to default

[Ashish Jangam]

This patch changes the irq state from high to the now default low
state.

This patch is dependent on the DA9055 MFD.

This patch is tested on smdk6410 board.

Signed-off-by: Ashish Jangam <ashish.jangam@kpitcummins.com>
---
 drivers/hwmon/da9055-hwmon.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/hwmon/da9055-hwmon.c b/drivers/hwmon/da9055-hwmon.c
index 9465c05..dfd0db1 100644
--- a/drivers/hwmon/da9055-hwmon.c
+++ b/drivers/hwmon/da9055-hwmon.c
@@ -284,7 +284,7 @@ static int da9055_hwmon_probe(struct platform_device *pdev)
 
 	ret = devm_request_threaded_irq(&pdev->dev, hwmon_irq,
 					NULL, da9055_auxadc_irq,
-					IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
+					IRQF_TRIGGER_LOW | IRQF_ONESHOT,
 					"adc-irq", hwmon);
 	if (ret != 0) {
 		dev_err(hwmon->da9055->dev, "DA9055 ADC IRQ failed ret=%d\n",
-- 
1.7.0.4

Re: [patch v1 3/5] hwmon: da9055 change irq state to default

[Guenter Roeck]

On Fri, Jan 18, 2013 at 10:54:52AM +0530, Ashish Jangam wrote:
> This patch changes the irq state from high to the now default low
> state.
> 
> This patch is dependent on the DA9055 MFD.
> 
That statement is a bit confusing. Do you mean it depends on a patch submitted
for the DA9055 MFD ?

In other words, should this patch be pushed upstream through the mfd tree,
or through the hwmon tree ?

> This patch is tested on smdk6410 board.
> 
> Signed-off-by: Ashish Jangam <ashish.jangam@kpitcummins.com>

Acked-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/hwmon/da9055-hwmon.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/hwmon/da9055-hwmon.c b/drivers/hwmon/da9055-hwmon.c
> index 9465c05..dfd0db1 100644
> --- a/drivers/hwmon/da9055-hwmon.c
> +++ b/drivers/hwmon/da9055-hwmon.c
> @@ -284,7 +284,7 @@ static int da9055_hwmon_probe(struct platform_device *pdev)
>  
>  	ret = devm_request_threaded_irq(&pdev->dev, hwmon_irq,
>  					NULL, da9055_auxadc_irq,
> -					IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
> +					IRQF_TRIGGER_LOW | IRQF_ONESHOT,
>  					"adc-irq", hwmon);
>  	if (ret != 0) {
>  		dev_err(hwmon->da9055->dev, "DA9055 ADC IRQ failed ret=%d\n",
> -- 
> 1.7.0.4
> 
> 
>