* [PATCH] ARM: shmobile: armadillo800eva: set clock rates before timer init
@ 2013-01-18 5:02 Hideki EIRAKU
2013-01-18 6:28 ` Kuninori Morimoto
2013-01-30 4:23 ` Simon Horman
0 siblings, 2 replies; 3+ messages in thread
From: Hideki EIRAKU @ 2013-01-18 5:02 UTC (permalink / raw)
To: Simon Horman, Magnus Damm, Russell King
Cc: Kuninori Morimoto, Damian Hobson-Garcia, Katsuya MATSUBARA,
linux-sh, linux-arm-kernel, linux-kernel, Hideki EIRAKU
Previously clock rates were set after initialization of timer.
Therefore the timer used the default extal1 clock rate (25MHz)
instead of the correct rate for this board (24MHz).
Signed-off-by: Hideki EIRAKU <hdk@igel.co.jp>
---
arch/arm/mach-shmobile/board-armadillo800eva.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-shmobile/board-armadillo800eva.c b/arch/arm/mach-shmobile/board-armadillo800eva.c
index 5353adf..1e79cfb 100644
--- a/arch/arm/mach-shmobile/board-armadillo800eva.c
+++ b/arch/arm/mach-shmobile/board-armadillo800eva.c
@@ -1175,8 +1175,6 @@ static void __init eva_init(void)
platform_add_devices(eva_devices,
ARRAY_SIZE(eva_devices));
- eva_clock_init();
-
rmobile_add_device_to_domain("A4LC", &lcdc0_device);
rmobile_add_device_to_domain("A4LC", &hdmi_lcdc_device);
if (usb)
@@ -1187,6 +1185,9 @@ static void __init eva_earlytimer_init(void)
{
r8a7740_clock_init(MD_CK0 | MD_CK2);
shmobile_earlytimer_init();
+
+ /* the rate of extal1 clock must be set before late_time_init */
+ eva_clock_init();
}
static void __init eva_add_early_devices(void)
--
1.8.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: shmobile: armadillo800eva: set clock rates before timer init
2013-01-18 5:02 [PATCH] ARM: shmobile: armadillo800eva: set clock rates before timer init Hideki EIRAKU
@ 2013-01-18 6:28 ` Kuninori Morimoto
2013-01-30 4:23 ` Simon Horman
1 sibling, 0 replies; 3+ messages in thread
From: Kuninori Morimoto @ 2013-01-18 6:28 UTC (permalink / raw)
To: Hideki EIRAKU
Cc: Simon Horman, Magnus Damm, Russell King, Damian Hobson-Garcia,
Katsuya MATSUBARA, linux-sh, linux-arm-kernel, linux-kernel
> Previously clock rates were set after initialization of timer.
> Therefore the timer used the default extal1 clock rate (25MHz)
> instead of the correct rate for this board (24MHz).
>
> Signed-off-by: Hideki EIRAKU <hdk@igel.co.jp>
> ---
> arch/arm/mach-shmobile/board-armadillo800eva.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: shmobile: armadillo800eva: set clock rates before timer init
2013-01-18 5:02 [PATCH] ARM: shmobile: armadillo800eva: set clock rates before timer init Hideki EIRAKU
2013-01-18 6:28 ` Kuninori Morimoto
@ 2013-01-30 4:23 ` Simon Horman
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2013-01-30 4:23 UTC (permalink / raw)
To: Hideki EIRAKU
Cc: Magnus Damm, Russell King, Kuninori Morimoto,
Damian Hobson-Garcia, Katsuya MATSUBARA, linux-sh,
linux-arm-kernel, linux-kernel
On Fri, Jan 18, 2013 at 02:02:05PM +0900, Hideki EIRAKU wrote:
> Previously clock rates were set after initialization of timer.
> Therefore the timer used the default extal1 clock rate (25MHz)
> instead of the correct rate for this board (24MHz).
>
> Signed-off-by: Hideki EIRAKU <hdk@igel.co.jp>
Thanks, I have applied this to the boards2 branch
and will merge it into the next branch.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-30 4:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-18 5:02 [PATCH] ARM: shmobile: armadillo800eva: set clock rates before timer init Hideki EIRAKU
2013-01-18 6:28 ` Kuninori Morimoto
2013-01-30 4:23 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®