[PATCH] checkpatch: fix USLEEP_RANGE test

[PATCH] checkpatch: fix USLEEP_RANGE test

[Bruce Allan]

Do not test udelay() for a value less than 10usec when passed a variable
instead of a hard-coded number; there is no way for checkpatch to know the
value of the variable.  As it is today, it will complain about variables
with alphanumeric characters plus '_', e.g. foo_bar, but not variables with
other characters, eg. foo->bar.

Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Cc: Andy Whitcroft <apw@canonical.com>
---
 scripts/checkpatch.pl |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 4d2c7df..adfb2f6 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3237,9 +3237,9 @@ sub process {
 		}
 
 # prefer usleep_range over udelay
-		if ($line =~ /\budelay\s*\(\s*(\w+)\s*\)/) {
+		if ($line =~ /\budelay\s*\(\s*(\d+)\s*\)/) {
 			# ignore udelay's < 10, however
-			if (! (($1 =~ /(\d+)/) && ($1 < 10)) ) {
+			if (! ($1 < 10) ) {
 				CHK("USLEEP_RANGE",
 				    "usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt\n" . $line);
 			}

Re: [PATCH] checkpatch: fix USLEEP_RANGE test

[Joe Perches]

On Wed, 2013-01-30 at 11:15 -0800, Bruce Allan wrote:
> Do not test udelay() for a value less than 10usec when passed a variable
> instead of a hard-coded number;
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -3237,9 +3237,9 @@ sub process {
[]
>  # prefer usleep_range over udelay
> -		if ($line =~ /\budelay\s*\(\s*(\w+)\s*\)/) {
> +		if ($line =~ /\budelay\s*\(\s*(\d+)\s*\)/) {
>  			# ignore udelay's < 10, however
> -			if (! (($1 =~ /(\d+)/) && ($1 < 10)) ) {
> +			if (! ($1 < 10) ) {
>  				CHK("USLEEP_RANGE",
>  				    "usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt\n" . $line);
>  			}

Thanks Bruce.

Just a trivial comment:

Maybe this would be a little neater as

		if ($line =~ \budelay\s*\(\s*(\d+)\s*\) &&
		    $1 >= 10) {
			CHK(etc...)
		}

No worries though.