From: Shawn Guo <shawn.guo@linaro.org>
To: Thierry Reding <thierry.reding@avionic-design.de>
Cc: Chris Ball <cjb@laptop.org>, <linux-mmc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mmc: sdhci-esdhc-imx: Remove unused variables
Date: Thu, 31 Jan 2013 08:31:20 +0800 [thread overview]
Message-ID: <20130131003118.GC2765@S2101-09.ap.freescale.net> (raw)
In-Reply-To: <1359576681-14797-1-git-send-email-thierry.reding@avionic-design.de>
On Wed, Jan 30, 2013 at 09:11:21PM +0100, Thierry Reding wrote:
> Commit 3f175a6 (mmc: sdhci-esdhc-imx: remove ESDHC_CD_GPIO handling from
> IO accessory) removed all the code that was using these variables, so it
> is safe to drop them.
>
> Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
Thanks for the fixing, Thierry. But Chris has already queued a fix [1]
from Fabio.
Shawn
[1] http://thread.gmane.org/gmane.linux.kernel.mmc/18724
> ---
> drivers/mmc/host/sdhci-esdhc-imx.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
> index ae68bc9..509be3a 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -144,10 +144,6 @@ static inline void esdhc_clrset_le(struct sdhci_host *host, u32 mask, u32 val, i
>
> static u32 esdhc_readl_le(struct sdhci_host *host, int reg)
> {
> - struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
> - struct pltfm_imx_data *imx_data = pltfm_host->priv;
> - struct esdhc_platform_data *boarddata = &imx_data->boarddata;
> -
> u32 val = readl(host->ioaddr + reg);
>
> if (unlikely(reg == SDHCI_CAPABILITIES)) {
> @@ -178,7 +174,6 @@ static void esdhc_writel_le(struct sdhci_host *host, u32 val, int reg)
> {
> struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
> struct pltfm_imx_data *imx_data = pltfm_host->priv;
> - struct esdhc_platform_data *boarddata = &imx_data->boarddata;
> u32 data;
>
> if (unlikely(reg == SDHCI_INT_ENABLE || reg == SDHCI_SIGNAL_ENABLE)) {
> --
> 1.8.1.2
>
next prev parent reply other threads:[~2013-01-31 0:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-30 20:11 Thierry Reding
2013-01-31 0:31 ` Shawn Guo [this message]
2013-01-31 7:00 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130131003118.GC2765@S2101-09.ap.freescale.net \
--to=shawn.guo@linaro.org \
--cc=cjb@laptop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®