From: Fabio Baltieri <fabio.baltieri@linaro.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
linaro-dev@lists.linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: governors: implement generic policy_is_shared
Date: Thu, 31 Jan 2013 09:55:55 +0100 [thread overview]
Message-ID: <20130131085555.GB30667@balto.lan> (raw)
In-Reply-To: <CAKohponV-PPO8sqF=rzONLzPi7q-YFOPbrQgoBcNt_NjTJO6WQ@mail.gmail.com>
On Thu, Jan 31, 2013 at 02:01:27PM +0530, Viresh Kumar wrote:
> On 31 January 2013 13:44, Fabio Baltieri <fabio.baltieri@linaro.org> wrote:
> > Implement a generic helper function policy_is_shared() to replace the
> > current dbs_sw_coordinated_cpus() at cpufreq level, so that it can be
> > used by code other than cpufreq governors.
> >
> > Suggested-by: Viresh Kumar <viresh.kumar@linaro.org>
> > Signed-off-by: Fabio Baltieri <fabio.baltieri@linaro.org>
> > ---
> > drivers/cpufreq/cpufreq_conservative.c | 2 +-
> > drivers/cpufreq/cpufreq_governor.c | 8 --------
> > drivers/cpufreq/cpufreq_governor.h | 1 -
> > drivers/cpufreq/cpufreq_ondemand.c | 2 +-
> > include/linux/cpufreq.h | 5 +++++
>
> Great,
>
> But, you missed few places:
>
> drivers/cpufreq/acpi-cpufreq.c: if (bios_with_sw_any_bug &&
> cpumask_weight(policy->cpus) == 1) {
> drivers/cpufreq/cpufreq_stats.c: if (policy &&
> (cpumask_weight(policy->cpus) == 1)) {
This doesn't look like the same thing to me! Isn't this check here just
to trigger during init (exit) on the first (last) cpu? How would you
replace it?
Fabio
> get these fixed too and add my
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
Fabio Baltieri
next prev parent reply other threads:[~2013-01-31 8:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 8:14 Fabio Baltieri
2013-01-31 8:31 ` Viresh Kumar
2013-01-31 8:55 ` Fabio Baltieri [this message]
2013-01-31 8:58 ` Viresh Kumar
2013-01-31 9:44 ` [PATCH v2] " Fabio Baltieri
2013-01-31 9:53 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130131085555.GB30667@balto.lan \
--to=fabio.baltieri@linaro.org \
--cc=cpufreq@vger.kernel.org \
--cc=linaro-dev@lists.linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®