* [patch v1 4/5] rtc: da9055 change irq state to default
@ 2013-01-18 5:26 Ashish Jangam
2013-01-18 6:10 ` devendra.aaru
0 siblings, 1 reply; 3+ messages in thread
From: Ashish Jangam @ 2013-01-18 5:26 UTC (permalink / raw)
To: Andrew Morton, Alessandro Zummo; +Cc: Samuel Ortiz, rtc-linux, linux-kernel
This patch changes the irq state from high to the now default low
state.
This patch is dependent on the DA9055 MFD.
This patch is tested on smdk6410 board.
Signed-off-by: Ashish Jangam <ashish.jangam@kpitcummins.com>
---
drivers/rtc/rtc-da9055.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/rtc/rtc-da9055.c b/drivers/rtc/rtc-da9055.c
index 8f0dcfe..918b16b 100644
--- a/drivers/rtc/rtc-da9055.c
+++ b/drivers/rtc/rtc-da9055.c
@@ -305,7 +305,7 @@ static int da9055_rtc_probe(struct platform_device *pdev)
alm_irq = regmap_irq_get_virq(rtc->da9055->irq_data, alm_irq);
ret = devm_request_threaded_irq(&pdev->dev, alm_irq, NULL,
da9055_rtc_alm_irq,
- IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
+ IRQF_TRIGGER_LOW | IRQF_ONESHOT,
"ALM", rtc);
if (ret != 0)
dev_err(rtc->da9055->dev, "irq registration failed: %d\n", ret);
--
1.7.0.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch v1 4/5] rtc: da9055 change irq state to default
2013-01-18 5:26 [patch v1 4/5] rtc: da9055 change irq state to default Ashish Jangam
@ 2013-01-18 6:10 ` devendra.aaru
2013-01-31 22:42 ` [rtc-linux] " Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: devendra.aaru @ 2013-01-18 6:10 UTC (permalink / raw)
To: Ashish Jangam
Cc: Andrew Morton, Alessandro Zummo, Samuel Ortiz, rtc-linux, linux-kernel
On Fri, Jan 18, 2013 at 12:26 AM, Ashish Jangam
<ashish.jangam@kpitcummins.com> wrote:
> This patch changes the irq state from high to the now default low
> state.
>
will you please provide more info on why do we need to set it to low state?
> This patch is dependent on the DA9055 MFD.
>
> This patch is tested on smdk6410 board.
>
> Signed-off-by: Ashish Jangam <ashish.jangam@kpitcummins.com>
> ---
> drivers/rtc/rtc-da9055.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/rtc/rtc-da9055.c b/drivers/rtc/rtc-da9055.c
> index 8f0dcfe..918b16b 100644
> --- a/drivers/rtc/rtc-da9055.c
> +++ b/drivers/rtc/rtc-da9055.c
> @@ -305,7 +305,7 @@ static int da9055_rtc_probe(struct platform_device *pdev)
> alm_irq = regmap_irq_get_virq(rtc->da9055->irq_data, alm_irq);
> ret = devm_request_threaded_irq(&pdev->dev, alm_irq, NULL,
> da9055_rtc_alm_irq,
> - IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
> + IRQF_TRIGGER_LOW | IRQF_ONESHOT,
> "ALM", rtc);
> if (ret != 0)
> dev_err(rtc->da9055->dev, "irq registration failed: %d\n", ret);
> --
> 1.7.0.4
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [rtc-linux] Re: [patch v1 4/5] rtc: da9055 change irq state to default
2013-01-18 6:10 ` devendra.aaru
@ 2013-01-31 22:42 ` Andrew Morton
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2013-01-31 22:42 UTC (permalink / raw)
To: rtc-linux
Cc: devendra.aaru, Ashish Jangam, Alessandro Zummo, Samuel Ortiz,
linux-kernel
On Fri, 18 Jan 2013 01:10:40 -0500
"devendra.aaru" <devendra.aaru@gmail.com> wrote:
> On Fri, Jan 18, 2013 at 12:26 AM, Ashish Jangam
> <ashish.jangam@kpitcummins.com> wrote:
> > This patch changes the irq state from high to the now default low
> > state.
> >
>
> will you please provide more info on why do we need to set it to low state?
Yes, I would also like more details about this patch, please.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-31 22:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-18 5:26 [patch v1 4/5] rtc: da9055 change irq state to default Ashish Jangam
2013-01-18 6:10 ` devendra.aaru
2013-01-31 22:42 ` [rtc-linux] " Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®