[PATCH] PM / devfreq: fix missing unlock on error in exynos4_busfreq_pm_notifier_event()

[PATCH] PM / devfreq: fix missing unlock on error in exynos4_busfreq_pm_notifier_event()

[Wei Yongjun]

From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Add the missing unlock before return from function
exynos4_busfreq_pm_notifier_event() in the error
handling case.

This issue introduced by commit 8fa938
(PM / devfreq: exynos4_bus: honor RCU lock usage)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
 drivers/devfreq/exynos4_bus.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/devfreq/exynos4_bus.c b/drivers/devfreq/exynos4_bus.c
index 46d94e9..6208a68 100644
--- a/drivers/devfreq/exynos4_bus.c
+++ b/drivers/devfreq/exynos4_bus.c
@@ -974,6 +974,7 @@ static int exynos4_busfreq_pm_notifier_event(struct notifier_block *this,
 			rcu_read_unlock();
 			dev_err(data->dev, "%s: unable to find a min freq\n",
 				__func__);
+			mutex_unlock(&data->lock);
 			return PTR_ERR(opp);
 		}
 		new_oppinfo.rate = opp_get_freq(opp);

Re: [PATCH] PM / devfreq: fix missing unlock on error in exynos4_busfreq_pm_notifier_event()

[Nishanth Menon]

On 12:33-20130222, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> Add the missing unlock before return from function
> exynos4_busfreq_pm_notifier_event() in the error
> handling case.
> 
> This issue introduced by commit 8fa938
> (PM / devfreq: exynos4_bus: honor RCU lock usage)
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
>  drivers/devfreq/exynos4_bus.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/devfreq/exynos4_bus.c b/drivers/devfreq/exynos4_bus.c
> index 46d94e9..6208a68 100644
> --- a/drivers/devfreq/exynos4_bus.c
> +++ b/drivers/devfreq/exynos4_bus.c
> @@ -974,6 +974,7 @@ static int exynos4_busfreq_pm_notifier_event(struct notifier_block *this,
>  			rcu_read_unlock();
>  			dev_err(data->dev, "%s: unable to find a min freq\n",
>  				__func__);
> +			mutex_unlock(&data->lock);
>  			return PTR_ERR(opp);
>  		}
>  		new_oppinfo.rate = opp_get_freq(opp);
> 
> 
Arrgh.. Thanks for catching this :( My bad.

Fix looks good to me. upto  MyungJoo.

MyungJoo, Rafael,
btw, adding linux-pm@vger.kernel.org to  MAINTAINERS for devfreq might
be a nice idea to have right audience.
-- 
Regards,
Nishanth Menon

Re: Re: [PATCH] PM / devfreq: fix missing unlock on error in exynos4_busfreq_pm_notifier_event()

[MyungJoo Ham]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=euc-kr, Size: 1040 bytes --]

> On 12:33-20130222, Wei Yongjun wrote:
> > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> > 
> > Add the missing unlock before return from function
> > exynos4_busfreq_pm_notifier_event() in the error
> > handling case.
> > 
> > This issue introduced by commit 8fa938
> > (PM / devfreq: exynos4_bus: honor RCU lock usage)
> > 
> > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> Arrgh.. Thanks for catching this :( My bad.
> 
> Fix looks good to me. upto  MyungJoo.

Applied to devfreq repository.
I'll send pull request to Rafael soon along with other patches.

> 
> MyungJoo, Rafael,
> btw, adding linux-pm@vger.kernel.org to  MAINTAINERS for devfreq might
> be a nice idea to have right audience.

It appears that replacing the current mailing list address with linux-pm is appropriate. If no one objects, I'll post the suggestion later.


Cheers,
MyungJoo

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [PATCH] PM / devfreq: fix missing unlock on error in exynos4_busfreq_pm_notifier_event()

[Rafael J. Wysocki]

On Friday, February 22, 2013 06:33:58 AM MyungJoo Ham wrote:
> > On 12:33-20130222, Wei Yongjun wrote:
> > > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> > > 
> > > Add the missing unlock before return from function
> > > exynos4_busfreq_pm_notifier_event() in the error
> > > handling case.
> > > 
> > > This issue introduced by commit 8fa938
> > > (PM / devfreq: exynos4_bus: honor RCU lock usage)
> > > 
> > > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> > Arrgh.. Thanks for catching this :( My bad.
> > 
> > Fix looks good to me. upto  MyungJoo.
> 
> Applied to devfreq repository.
> I'll send pull request to Rafael soon along with other patches.
> 
> > 
> > MyungJoo, Rafael,
> > btw, adding linux-pm@vger.kernel.org to  MAINTAINERS for devfreq might
> > be a nice idea to have right audience.
> 
> It appears that replacing the current mailing list address with linux-pm is
> appropriate. If no one objects, I'll post the suggestion later.

Sure, please do.

Thanks,
Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.