[patch] drivers, vmci: vmware vmci driver depends on CONFIG_NET

[patch] drivers, vmci: vmware vmci driver depends on CONFIG_NET

[David Rientjes]

CONFIG_VMWARE_VMCI requires CONFIG_NET, otherwise there is a link error:

drivers/built-in.o: In function `__qp_memcpy_from_queue.isra.11':
vmci_queue_pair.c:(.text+0x2d4509): undefined reference to `memcpy_toiovec'
drivers/built-in.o: In function `__qp_memcpy_to_queue.isra.12':
vmci_queue_pair.c:(.text+0x2d4709): undefined reference to `memcpy_fromiovec'

Signed-off-by: David Rientjes <rientjes@google.com>
---
 drivers/misc/vmw_vmci/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/vmw_vmci/Kconfig b/drivers/misc/vmw_vmci/Kconfig
--- a/drivers/misc/vmw_vmci/Kconfig
+++ b/drivers/misc/vmw_vmci/Kconfig
@@ -4,7 +4,7 @@
 
 config VMWARE_VMCI
 	tristate "VMware VMCI Driver"
-	depends on X86 && PCI
+	depends on X86 && PCI && NET
 	help
 	  This is VMware's Virtual Machine Communication Interface.  It enables
 	  high-speed communication between host and guest in a virtual

Re: [patch] drivers, vmci: vmware vmci driver depends on CONFIG_NET

[David Rientjes]

On Thu, 21 Feb 2013, David Rientjes wrote:

> CONFIG_VMWARE_VMCI requires CONFIG_NET, otherwise there is a link error:
> 
> drivers/built-in.o: In function `__qp_memcpy_from_queue.isra.11':
> vmci_queue_pair.c:(.text+0x2d4509): undefined reference to `memcpy_toiovec'
> drivers/built-in.o: In function `__qp_memcpy_to_queue.isra.12':
> vmci_queue_pair.c:(.text+0x2d4709): undefined reference to `memcpy_fromiovec'
> 

This link error has made it to Linus' tree, so hopefully this can be 
merged and pushed before rc1.

Re: [patch] drivers, vmci: vmware vmci driver depends on CONFIG_NET

[Greg Kroah-Hartman]

On Fri, Feb 22, 2013 at 12:37:29PM -0800, David Rientjes wrote:
> On Thu, 21 Feb 2013, David Rientjes wrote:
> 
> > CONFIG_VMWARE_VMCI requires CONFIG_NET, otherwise there is a link error:
> > 
> > drivers/built-in.o: In function `__qp_memcpy_from_queue.isra.11':
> > vmci_queue_pair.c:(.text+0x2d4509): undefined reference to `memcpy_toiovec'
> > drivers/built-in.o: In function `__qp_memcpy_to_queue.isra.12':
> > vmci_queue_pair.c:(.text+0x2d4709): undefined reference to `memcpy_fromiovec'
> > 
> 
> This link error has made it to Linus' tree, so hopefully this can be 
> merged and pushed before rc1.

Yes, give me a chance, it's still early in the merge window.  Actually,
for something so trivial as this, it will probably wait until after
3.9-rc1 is out, the number of people who build a running system without
CONFIG_NET is probably pretty small :)

Don't worry, the patch is not lost, it's in my "to-apply" queue.

thanks,

greg k-h