* [PATCH 4/4] block: IBM RamSan 70/80 error message bug fix.
@ 2013-02-25 19:09 Philip J. Kelleher
0 siblings, 0 replies; only message in thread
From: Philip J. Kelleher @ 2013-02-25 19:09 UTC (permalink / raw)
To: axboe; +Cc: linux-kernel, brking, josh.h.morris
From: Philip J Kelleher <pjk1939@linux.vnet.ibm.com>
This patch includes a simple change to the rsxx_pci_remove
function that caused error messages because traffic was halted
too early.
Signed-off-by: Philip J Kelleher <pjk1939@linux.vnet.ibm.com>
-------------------------------------------------------------------------------
diff -uprN -X linux-block-vanilla/Documentation/dontdiff linux-block-vanilla/drivers/block/rsxx/core.c linux-block/drivers/block/rsxx/core.c
--- linux-block-vanilla/drivers/block/rsxx/core.c 2013-02-25 11:23:39.077245757 -0600
+++ linux-block/drivers/block/rsxx/core.c 2013-02-25 11:24:39.446183327 -0600
@@ -538,9 +538,6 @@ static void rsxx_pci_remove(struct pci_d
rsxx_disable_ier_and_isr(card, CR_INTR_EVENT);
spin_unlock_irqrestore(&card->irq_lock, flags);
- /* Prevent work_structs from re-queuing themselves. */
- card->halt = 1;
-
cancel_work_sync(&card->event_work);
rsxx_destroy_dev(card);
@@ -549,6 +546,10 @@ static void rsxx_pci_remove(struct pci_d
spin_lock_irqsave(&card->irq_lock, flags);
rsxx_disable_ier_and_isr(card, CR_INTR_ALL);
spin_unlock_irqrestore(&card->irq_lock, flags);
+
+ /* Prevent work_structs from re-queuing themselves. */
+ card->halt = 1;
+
free_irq(dev->irq, card);
if (!force_legacy)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2013-02-25 19:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-25 19:09 [PATCH 4/4] block: IBM RamSan 70/80 error message bug fix Philip J. Kelleher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®