Re: [PATCH v5 7/8] v4l2: Add private controls base for SI476X

[Hans Verkuil <hverkuil@xs4all.nl>]

On Tue February 26 2013 07:38:53 Andrey Smirnov wrote:
> Add a base to be used for allocation of all the SI476X specific
> controls in the corresponding driver.
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
>  include/uapi/linux/v4l2-controls.h |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h
> index 296d20e..133703d 100644
> --- a/include/uapi/linux/v4l2-controls.h
> +++ b/include/uapi/linux/v4l2-controls.h
> @@ -147,6 +147,10 @@ enum v4l2_colorfx {
>   * of controls. We reserve 16 controls for this driver. */
>  #define V4L2_CID_USER_MEYE_BASE			(V4L2_CID_USER_BASE + 0x1000)
>  
> +/* The base for the si476x driver controls. See include/media/si476x.h for the list
> + * of controls. */
> +#define V4L2_CID_USER_SI476X_BASE		(V4L2_CID_USER_BASE + 0x2000)

Please make this consecutive to MEYE_BASE, so '+ 0x1010'. That makes it easy
to keep track of these control ranges.

Regards,

	Hans

> +
>  /* MPEG-class control IDs */
>  
>  #define V4L2_CID_MPEG_BASE 			(V4L2_CTRL_CLASS_MPEG | 0x900)
>