* [PATCH 1/1] arm: remove extra semicolon in if statement
@ 2013-03-01 4:25 Vinicius Tinti
2013-03-01 8:36 ` Uwe Kleine-König
0 siblings, 1 reply; 3+ messages in thread
From: Vinicius Tinti @ 2013-03-01 4:25 UTC (permalink / raw)
To: Peter Zijlstra, Paul Mackerras, Ingo Molnar,
Arnaldo Carvalho de Melo, Will Deacon, Russell King
Cc: linux-arm-kernel, linux-kernel, Vinicius Tinti
Remove extra semicolon in perf_event.c if statement.
Signed-off-by: Vinicius Tinti <viniciustinti@gmail.com>
---
arch/arm/kernel/perf_event.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/kernel/perf_event.c b/arch/arm/kernel/perf_event.c
index 31e0eb3..a892067 100644
--- a/arch/arm/kernel/perf_event.c
+++ b/arch/arm/kernel/perf_event.c
@@ -400,7 +400,7 @@ __hw_perf_event_init(struct perf_event *event)
}
if (event->group_leader != event) {
- if (validate_group(event) != 0);
+ if (validate_group(event) != 0)
return -EINVAL;
}
--
1.7.9.5
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] arm: remove extra semicolon in if statement
2013-03-01 4:25 [PATCH 1/1] arm: remove extra semicolon in if statement Vinicius Tinti
@ 2013-03-01 8:36 ` Uwe Kleine-König
2013-03-01 9:15 ` Mark Rutland
0 siblings, 1 reply; 3+ messages in thread
From: Uwe Kleine-König @ 2013-03-01 8:36 UTC (permalink / raw)
To: Vinicius Tinti
Cc: Peter Zijlstra, Paul Mackerras, Ingo Molnar,
Arnaldo Carvalho de Melo, Will Deacon, Russell King,
linux-kernel, linux-arm-kernel
Hello,
On Fri, Mar 01, 2013 at 01:25:52AM -0300, Vinicius Tinti wrote:
> Remove extra semicolon in perf_event.c if statement.
The commit log sounds like a style fix, but your patch introduces a
semantical change. I suspect this patch fixes a real bug, you should
point that out here.
Best regards
Uwe
>
> Signed-off-by: Vinicius Tinti <viniciustinti@gmail.com>
> ---
> arch/arm/kernel/perf_event.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/kernel/perf_event.c b/arch/arm/kernel/perf_event.c
> index 31e0eb3..a892067 100644
> --- a/arch/arm/kernel/perf_event.c
> +++ b/arch/arm/kernel/perf_event.c
> @@ -400,7 +400,7 @@ __hw_perf_event_init(struct perf_event *event)
> }
>
> if (event->group_leader != event) {
> - if (validate_group(event) != 0);
> + if (validate_group(event) != 0)
> return -EINVAL;
> }
>
> --
> 1.7.9.5
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] arm: remove extra semicolon in if statement
2013-03-01 8:36 ` Uwe Kleine-König
@ 2013-03-01 9:15 ` Mark Rutland
0 siblings, 0 replies; 3+ messages in thread
From: Mark Rutland @ 2013-03-01 9:15 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Vinicius Tinti, Russell King, Peter Zijlstra, Will Deacon,
linux-kernel, Ingo Molnar, Paul Mackerras,
Arnaldo Carvalho de Melo, linux-arm-kernel
On Fri, Mar 01, 2013 at 08:36:24AM +0000, Uwe Kleine-König wrote:
> Hello,
>
> On Fri, Mar 01, 2013 at 01:25:52AM -0300, Vinicius Tinti wrote:
> > Remove extra semicolon in perf_event.c if statement.
> The commit log sounds like a style fix, but your patch introduces a
> semantical change. I suspect this patch fixes a real bug, you should
> point that out here.
>
> Best regards
> Uwe
It does fix a real bug, but Will already has a fix [1]. It's in rmk's patch
tracking system as 7664/1.
Thanks,
Mark.
[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2013-February/151564.html
> >
> > Signed-off-by: Vinicius Tinti <viniciustinti@gmail.com>
> > ---
> > arch/arm/kernel/perf_event.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/kernel/perf_event.c b/arch/arm/kernel/perf_event.c
> > index 31e0eb3..a892067 100644
> > --- a/arch/arm/kernel/perf_event.c
> > +++ b/arch/arm/kernel/perf_event.c
> > @@ -400,7 +400,7 @@ __hw_perf_event_init(struct perf_event *event)
> > }
> >
> > if (event->group_leader != event) {
> > - if (validate_group(event) != 0);
> > + if (validate_group(event) != 0)
> > return -EINVAL;
> > }
> >
> > --
> > 1.7.9.5
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> >
>
> --
> Pengutronix e.K. | Uwe Kleine-König |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-01 9:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-01 4:25 [PATCH 1/1] arm: remove extra semicolon in if statement Vinicius Tinti
2013-03-01 8:36 ` Uwe Kleine-König
2013-03-01 9:15 ` Mark Rutland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®