mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: torvalds@linux-foundation.org
Cc: linux-arch@vger.kernel.org, sfr@canb.auug.org.au,
	linux-m32r@ml.linux-m32r.org, Joakim.Tjernlund@transmode.se,
	arnd@arndb.de, Hirokazu Takata <takata@linux-m32r.org>,
	linux-kernel@vger.kernel.org, linux-m32r-ja@ml.linux-m32r.org,
	akpm@linux-foundation.org
Subject: [PATCH 4/4] UAPI: Fix endianness conditionals in M32R's asm/stat.h
Date: Wed, 06 Mar 2013 20:48:00 +0000	[thread overview]
Message-ID: <20130306204759.31327.7782.stgit@warthog.procyon.org.uk> (raw)
In-Reply-To: <20130306204724.31327.43118.stgit@warthog.procyon.org.uk>

In the UAPI header files, __BIG_ENDIAN and __LITTLE_ENDIAN must be compared
against __BYTE_ORDER in preprocessor conditionals where these are exposed to
userspace (that is they're not inside __KERNEL__ conditionals).

However, in the main kernel the norm is to check for "defined(__XXX_ENDIAN)"
rather than comparing against __BYTE_ORDER and this has incorrectly leaked
into the userspace headers.

The definition of struct stat64 in M32R's asm/stat.h is wrong in this way.
Note that userspace will likely interpret the field order incorrectly as the
big-endian variant on little-endian machines - depending on header inclusion
order.

[!!!] NOTE [!!!]  This patch may adversely change the userspace API.  It might
be better to fix the ordering of st_blocks and __pad4 in struct stat64.

Signed-off-by: David Howells <dhowells@redhat.com>
cc: Hirokazu Takata <takata@linux-m32r.org>
cc: linux-m32r@ml.linux-m32r.org
cc: linux-m32r-ja@ml.linux-m32r.org
---

 arch/m32r/include/uapi/asm/stat.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/m32r/include/uapi/asm/stat.h b/arch/m32r/include/uapi/asm/stat.h
index da4518f..98470fe 100644
--- a/arch/m32r/include/uapi/asm/stat.h
+++ b/arch/m32r/include/uapi/asm/stat.h
@@ -63,10 +63,10 @@ struct stat64 {
 	long long	st_size;
 	unsigned long	st_blksize;
 
-#if defined(__BIG_ENDIAN)
+#if defined(__BYTE_ORDER) ? __BYTE_ORDER == __BIG_ENDIAN : defined(__BIG_ENDIAN)
 	unsigned long	__pad4;		/* future possible st_blocks high bits */
 	unsigned long	st_blocks;	/* Number 512-byte blocks allocated. */
-#elif defined(__LITTLE_ENDIAN)
+#elif defined(__BYTE_ORDER) ? __BYTE_ORDER == __LITTLE_ENDIAN : defined(__LITTLE_ENDIAN)
 	unsigned long	st_blocks;	/* Number 512-byte blocks allocated. */
 	unsigned long	__pad4;		/* future possible st_blocks high bits */
 #else


      parent reply	other threads:[~2013-03-06 20:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-06 20:47 [RFC][PATCH 0/4] UAPI: Fix up endianness conditionals David Howells
2013-03-06 20:47 ` [PATCH 1/4] UAPI: Fix endianness conditionals in linux/aio_abi.h David Howells
2013-03-12 16:32   ` Benjamin LaHaise
2013-03-12 18:22     ` Jeff Moyer
2013-03-06 20:47 ` [PATCH 2/4] UAPI: Fix endianness conditionals in linux/acct.h David Howells
2013-03-06 20:47 ` [PATCH 3/4] UAPI: Fix endianness conditionals in linux/raid/md_p.h David Howells
2013-03-12  1:43   ` NeilBrown
2013-03-06 20:48 ` David Howells [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130306204759.31327.7782.stgit@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=Joakim.Tjernlund@transmode.se \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m32r-ja@ml.linux-m32r.org \
    --cc=linux-m32r@ml.linux-m32r.org \
    --cc=sfr@canb.auug.org.au \
    --cc=takata@linux-m32r.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®