* [PATCH] drm/i915: Fix missing variable initilization
@ 2013-02-24 22:35 Syam Sidhardhan
2013-03-03 17:20 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Syam Sidhardhan @ 2013-02-24 22:35 UTC (permalink / raw)
To: dri-devel, linux-kernel; +Cc: syamsidhardh, airlied, daniel.vetter
Need to initialize the variable wait to false.
Signed-off-by: Syam Sidhardhan <s.syam@samsung.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index fc95ef0..5d0a687 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -1391,8 +1391,8 @@ void intel_ddi_prepare_link_retrain(struct drm_encoder *encoder)
struct intel_dp *intel_dp = &intel_dig_port->dp;
struct drm_i915_private *dev_priv = encoder->dev->dev_private;
enum port port = intel_dig_port->port;
- bool wait;
uint32_t val;
+ bool wait = false;
if (I915_READ(DP_TP_CTL(port)) & DP_TP_CTL_ENABLE) {
val = I915_READ(DDI_BUF_CTL(port));
--
1.7.9.5
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/i915: Fix missing variable initilization
2013-02-24 22:35 [PATCH] drm/i915: Fix missing variable initilization Syam Sidhardhan
@ 2013-03-03 17:20 ` Daniel Vetter
2013-03-08 14:39 ` Damien Lespiau
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Vetter @ 2013-03-03 17:20 UTC (permalink / raw)
To: Syam Sidhardhan
Cc: dri-devel, linux-kernel, airlied, daniel.vetter, Paulo Zanoni
On Mon, Feb 25, 2013 at 04:05:38AM +0530, Syam Sidhardhan wrote:
> Need to initialize the variable wait to false.
>
> Signed-off-by: Syam Sidhardhan <s.syam@samsung.com>
Looks sane, thanks for the patch. Cc'ing Paulo in case I've missed
something.
-Daniel
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index fc95ef0..5d0a687 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -1391,8 +1391,8 @@ void intel_ddi_prepare_link_retrain(struct drm_encoder *encoder)
> struct intel_dp *intel_dp = &intel_dig_port->dp;
> struct drm_i915_private *dev_priv = encoder->dev->dev_private;
> enum port port = intel_dig_port->port;
> - bool wait;
> uint32_t val;
> + bool wait = false;
>
> if (I915_READ(DP_TP_CTL(port)) & DP_TP_CTL_ENABLE) {
> val = I915_READ(DDI_BUF_CTL(port));
> --
> 1.7.9.5
>
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/i915: Fix missing variable initilization
2013-03-03 17:20 ` Daniel Vetter
@ 2013-03-08 14:39 ` Damien Lespiau
0 siblings, 0 replies; 3+ messages in thread
From: Damien Lespiau @ 2013-03-08 14:39 UTC (permalink / raw)
To: Syam Sidhardhan, dri-devel, linux-kernel, airlied, Paulo Zanoni
On Sun, Mar 03, 2013 at 06:20:26PM +0100, Daniel Vetter wrote:
> On Mon, Feb 25, 2013 at 04:05:38AM +0530, Syam Sidhardhan wrote:
> > Need to initialize the variable wait to false.
> >
> > Signed-off-by: Syam Sidhardhan <s.syam@samsung.com>
>
> Looks sane, thanks for the patch. Cc'ing Paulo in case I've missed
> something.
FWIW, I posted a similar patch (without moving the variable around) on
intel-gfx yesterday, so:
Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
--
Damien
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-08 14:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-24 22:35 [PATCH] drm/i915: Fix missing variable initilization Syam Sidhardhan
2013-03-03 17:20 ` Daniel Vetter
2013-03-08 14:39 ` Damien Lespiau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®