mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] drm/i915: restrict kernel address leak in debugfs
@ 2013-03-11 19:25 Kees Cook
  2013-03-11 23:18 ` Daniel Vetter
  0 siblings, 1 reply; 2+ messages in thread
From: Kees Cook @ 2013-03-11 19:25 UTC (permalink / raw)
  To: linux-kernel; +Cc: Daniel Vetter, David Airlie, dri-devel

Masks kernel address info-leak in object dumps with the %pK suffix,
so they cannot be used to target kernel memory corruption attacks if
the kptr_restrict sysctl is set.

Signed-off-by: Kees Cook <keescook@chromium.org>
Cc: stable@vger.kernel.org
---
 drivers/gpu/drm/i915/i915_debugfs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index aae3148..7299ea4 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -103,7 +103,7 @@ static const char *cache_level_str(int type)
 static void
 describe_obj(struct seq_file *m, struct drm_i915_gem_object *obj)
 {
-	seq_printf(m, "%p: %s%s %8zdKiB %02x %02x %d %d %d%s%s%s",
+	seq_printf(m, "%pK: %s%s %8zdKiB %02x %02x %d %d %d%s%s%s",
 		   &obj->base,
 		   get_pin_flag(obj),
 		   get_tiling_flag(obj),
-- 
1.7.9.5


-- 
Kees Cook
Chrome OS Security

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/i915: restrict kernel address leak in debugfs
  2013-03-11 19:25 [PATCH] drm/i915: restrict kernel address leak in debugfs Kees Cook
@ 2013-03-11 23:18 ` Daniel Vetter
  0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2013-03-11 23:18 UTC (permalink / raw)
  To: Kees Cook; +Cc: linux-kernel, Daniel Vetter, David Airlie, dri-devel

On Mon, Mar 11, 2013 at 12:25:19PM -0700, Kees Cook wrote:
> Masks kernel address info-leak in object dumps with the %pK suffix,
> so they cannot be used to target kernel memory corruption attacks if
> the kptr_restrict sysctl is set.
> 
> Signed-off-by: Kees Cook <keescook@chromium.org>
> Cc: stable@vger.kernel.org
Picked up for -fixes, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-03-11 23:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-11 19:25 [PATCH] drm/i915: restrict kernel address leak in debugfs Kees Cook
2013-03-11 23:18 ` Daniel Vetter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®