[PATCH] usb: gadget: remove MACH_OMAP_H4_OTG

[PATCH] usb: gadget: remove MACH_OMAP_H4_OTG

[Paul Bolle]

The Kconfig option MACH_OMAP_H4_OTG was already considered dead as of
v2.6.36, as can be seen in commit
267ecec95f7d215d2da38252640b06198515acc3 ("Removing dead
MACH_OMAP_H4_OTG"). Remove its last trace now.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) Tested with "make ARCH=arm menuconfig" (specifically whether setting
either MACH_OMAP_H2 or MACH_OMAP_H3 still selected ISP1301_OMAP).

1) By the way "if ARCH_OMAP" on the next line seems superfluous, as
ARCH_OMAP1 already selects ARCH_OMAP. Minor nit, actually.

 drivers/usb/gadget/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
index 5a0c541..c65b5e2 100644
--- a/drivers/usb/gadget/Kconfig
+++ b/drivers/usb/gadget/Kconfig
@@ -194,7 +194,7 @@ config USB_FUSB300
 config USB_OMAP
 	tristate "OMAP USB Device Controller"
 	depends on ARCH_OMAP1
-	select ISP1301_OMAP if MACH_OMAP_H2 || MACH_OMAP_H3 || MACH_OMAP_H4_OTG
+	select ISP1301_OMAP if MACH_OMAP_H2 || MACH_OMAP_H3
 	select USB_OTG_UTILS if ARCH_OMAP
 	help
 	   Many Texas Instruments OMAP processors have flexible full
-- 
1.7.11.7

Re: [PATCH] usb: gadget: remove MACH_OMAP_H4_OTG

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 1319 bytes --]

On Mon, Mar 11, 2013 at 09:14:41PM +0100, Paul Bolle wrote:
> The Kconfig option MACH_OMAP_H4_OTG was already considered dead as of
> v2.6.36, as can be seen in commit
> 267ecec95f7d215d2da38252640b06198515acc3 ("Removing dead
> MACH_OMAP_H4_OTG"). Remove its last trace now.
> 
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> 0) Tested with "make ARCH=arm menuconfig" (specifically whether setting
> either MACH_OMAP_H2 or MACH_OMAP_H3 still selected ISP1301_OMAP).
> 
> 1) By the way "if ARCH_OMAP" on the next line seems superfluous, as
> ARCH_OMAP1 already selects ARCH_OMAP. Minor nit, actually.
> 
>  drivers/usb/gadget/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index 5a0c541..c65b5e2 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -194,7 +194,7 @@ config USB_FUSB300
>  config USB_OMAP
>  	tristate "OMAP USB Device Controller"
>  	depends on ARCH_OMAP1
> -	select ISP1301_OMAP if MACH_OMAP_H2 || MACH_OMAP_H3 || MACH_OMAP_H4_OTG
> +	select ISP1301_OMAP if MACH_OMAP_H2 || MACH_OMAP_H3

could you, instead, just remove the entire line ? we have an overuse of
select and this is one of those cases where it doesn't make sense.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] usb: gadget: remove MACH_OMAP_H4_OTG

[Paul Bolle]

On Thu, 2013-03-14 at 16:13 +0200, Felipe Balbi wrote:
> On Mon, Mar 11, 2013 at 09:14:41PM +0100, Paul Bolle wrote:
> > diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> > index 5a0c541..c65b5e2 100644
> > --- a/drivers/usb/gadget/Kconfig
> > +++ b/drivers/usb/gadget/Kconfig
> > @@ -194,7 +194,7 @@ config USB_FUSB300
> >  config USB_OMAP
> >  	tristate "OMAP USB Device Controller"
> >  	depends on ARCH_OMAP1
> > -	select ISP1301_OMAP if MACH_OMAP_H2 || MACH_OMAP_H3 || MACH_OMAP_H4_OTG
> > +	select ISP1301_OMAP if MACH_OMAP_H2 || MACH_OMAP_H3
> 
> could you, instead, just remove the entire line ? we have an overuse of
> select and this is one of those cases where it doesn't make sense.

Sure, but there's one problem: I need to come up with a descriptive
summary. "Remove "select" because Felipe told it makes no sense" might
not be good enough. Any hint why you think this entire line can be
dropped?


Paul Bolle

Re: [PATCH] usb: gadget: remove MACH_OMAP_H4_OTG

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 1659 bytes --]

On Thu, Mar 14, 2013 at 03:50:57PM +0100, Paul Bolle wrote:
> On Thu, 2013-03-14 at 16:13 +0200, Felipe Balbi wrote:
> > On Mon, Mar 11, 2013 at 09:14:41PM +0100, Paul Bolle wrote:
> > > diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> > > index 5a0c541..c65b5e2 100644
> > > --- a/drivers/usb/gadget/Kconfig
> > > +++ b/drivers/usb/gadget/Kconfig
> > > @@ -194,7 +194,7 @@ config USB_FUSB300
> > >  config USB_OMAP
> > >  	tristate "OMAP USB Device Controller"
> > >  	depends on ARCH_OMAP1
> > > -	select ISP1301_OMAP if MACH_OMAP_H2 || MACH_OMAP_H3 || MACH_OMAP_H4_OTG
> > > +	select ISP1301_OMAP if MACH_OMAP_H2 || MACH_OMAP_H3
> > 
> > could you, instead, just remove the entire line ? we have an overuse of
> > select and this is one of those cases where it doesn't make sense.
> 
> Sure, but there's one problem: I need to come up with a descriptive
> summary. "Remove "select" because Felipe told it makes no sense" might

heh :-) that'd look very funny 10 years from now ;-)

> not be good enough. Any hint why you think this entire line can be
> dropped?

How about:

"An improper use of 'select' has been proliferating through a bunch of
Kconfig files, this is just one instance of such case which prevents the
particular PHY driver to be enabled as a dynamically loaded module.

Users of the omap_udc, or any other UDC, should know that PHYs need to
be enabled in order for proper functionality. Based on that, we're
dropping the entire 'select' statement which will also remove warnings
further down the line when the PHY layer re-write is finished."

Sounds good to you ?

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]