* [patch] drivers, mfd: fix link error
@ 2013-03-21 19:08 David Rientjes
2013-03-21 20:51 ` Simon Glass
2013-03-21 23:55 ` Samuel Ortiz
0 siblings, 2 replies; 3+ messages in thread
From: David Rientjes @ 2013-03-21 19:08 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: Simon Glass, linux-kernel
CONFIG_MFD_CROS_EC requires CONFIG_MFD_CORE for a couple of functions that
are declared but not defined:
ERROR: "mfd_remove_devices" [drivers/mfd/cros_ec.ko] undefined!
ERROR: "mfd_add_devices" [drivers/mfd/cros_ec.ko] undefined!
Fix it by selecting CONFIG_MFD_CORE anytime CONFIG_MFD_CROS_EC is enabled.
Signed-off-by: David Rientjes <rientjes@google.com>
---
drivers/mfd/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -23,6 +23,7 @@ config MFD_88PM860X
config MFD_CROS_EC
tristate "Support ChromeOS Embedded Controller"
+ select MFD_CORE
help
If you say Y here you get support for the ChromeOS Embedded
Controller (EC) providing keyboard, battery and power services.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] drivers, mfd: fix link error
2013-03-21 19:08 [patch] drivers, mfd: fix link error David Rientjes
@ 2013-03-21 20:51 ` Simon Glass
2013-03-21 23:55 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2013-03-21 20:51 UTC (permalink / raw)
To: David Rientjes; +Cc: Samuel Ortiz, lk
On Thu, Mar 21, 2013 at 12:08 PM, David Rientjes <rientjes@google.com> wrote:
> CONFIG_MFD_CROS_EC requires CONFIG_MFD_CORE for a couple of functions that
> are declared but not defined:
>
> ERROR: "mfd_remove_devices" [drivers/mfd/cros_ec.ko] undefined!
> ERROR: "mfd_add_devices" [drivers/mfd/cros_ec.ko] undefined!
>
> Fix it by selecting CONFIG_MFD_CORE anytime CONFIG_MFD_CROS_EC is enabled.
>
> Signed-off-by: David Rientjes <rientjes@google.com>
Take 2
Acked-by: Simon Glass <sjg@chromium.org>
> ---
> drivers/mfd/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -23,6 +23,7 @@ config MFD_88PM860X
>
> config MFD_CROS_EC
> tristate "Support ChromeOS Embedded Controller"
> + select MFD_CORE
> help
> If you say Y here you get support for the ChromeOS Embedded
> Controller (EC) providing keyboard, battery and power services.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] drivers, mfd: fix link error
2013-03-21 19:08 [patch] drivers, mfd: fix link error David Rientjes
2013-03-21 20:51 ` Simon Glass
@ 2013-03-21 23:55 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Samuel Ortiz @ 2013-03-21 23:55 UTC (permalink / raw)
To: David Rientjes; +Cc: Simon Glass, linux-kernel
Hi David,
On Thu, Mar 21, 2013 at 12:08:33PM -0700, David Rientjes wrote:
> CONFIG_MFD_CROS_EC requires CONFIG_MFD_CORE for a couple of functions that
> are declared but not defined:
>
> ERROR: "mfd_remove_devices" [drivers/mfd/cros_ec.ko] undefined!
> ERROR: "mfd_add_devices" [drivers/mfd/cros_ec.ko] undefined!
>
> Fix it by selecting CONFIG_MFD_CORE anytime CONFIG_MFD_CROS_EC is enabled.
>
> Signed-off-by: David Rientjes <rientjes@google.com>
> ---
> drivers/mfd/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Patch applied, many thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-21 23:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-21 19:08 [patch] drivers, mfd: fix link error David Rientjes
2013-03-21 20:51 ` Simon Glass
2013-03-21 23:55 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®